AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
577 stars 193 forks source link

Easier way to highlight and underline texts like in MyBible #2501

Closed viktor-zhuromskyy closed 1 year ago

viktor-zhuromskyy commented 1 year ago

Please, need easier way to highlight and underline texts like in MyBible. The way it is implemented right now is very overburdening and time consuming.

Please consider the feature request!

agrogers commented 1 year ago

Hi Viktor,

I am not sure what you mean. I think AB is easier than MyBible and also more intuitative. Is this what you are trying to do? https://youtu.be/PXdvFRLGcAA

In brief:

  1. Click once on a verse to show the verse action dialog
  2. Click 'Bookmark+' button.
  3. That's it. However, if you want to label it with a category, you can then use recent labels or create new ones from the dialog.
  4. You can then add a note by dismissing that label dialog and pushing the edit button.

I personally pefer this over the long-press option that I use in MyBible. But I am not overly familiar with MyBible so maybe there is an easier way to do it there.

viktor-zhuromskyy commented 1 year ago

Hi Viktor,

I am not sure what you mean. I think AB is easier than MyBible and also more intuitative. Is this what you are trying to do? https://youtu.be/PXdvFRLGcAA

In brief:

  1. Click once on a verse to show the verse action dialog
  2. Click 'Bookmark+' button.
  3. That's it. However, if you want to label it with a category, you can then use recent labels or create new ones from the dialog.
  4. You can then add a note by dismissing that label dialog and pushing the edit button.

I personally pefer this over the long-press option that I use in MyBible. But I am not overly familiar with MyBible so maybe there is an easier way to do it there.

Hello, yes, I do want to do similar thing to what is implemented in And Bible, but it is cumbersome and cluttered action. In MyBible highlighting and underlying, as well as removal of the colored selection is implemented so easily that you spend mere seconds vs minutes as in And Bible.

On top of that, in my modules the highlighting feature does not work. Here is YouTube video link to the screencast, but in Russian. https://youtu.be/m7W5L5tQGuc

agrogers commented 1 year ago

OK, thanks for the video. That was helpful. I hadn't found that method of highlighting in MyBible. I had only ever used the Bookmark button.

I can see what you mean that you can highlight sections in seconds. After I make the selection, I can do the same in AndBible in about 5 secs :) But I understand that the workflow for highlighting in MyBible is very simple, and once I found it, very easy.

The problem I see with the MyBible quick underline/highlight is that it does not seem to link to a label/category. In AB, every bookmark has a label. I personally never bookmark without assigning a useful label. You could achieve much the same by creating labels called Green, Blue, Red etc and adding them as favourite labels. But it is one extra click for each highlight and the workflow is not as nice as MyBible.

However, adding highlighting without useful labels is not really what AB is trying to do. When it comes to labelling a verse or selection, I think AB is superior to MyBible in most (every?) way. But again, I havent used MyBible much so that assessment may be premature.

I think the biggest difficulty in incorporating the MyBible method is that we manage document windows very differently. The windowed approach in AB is very good and I think superior to MB.

Back to the quick highlight request, although I like it alot, it is beyond my programming skills to implement. And I suspect Tuomas is not convinced of its need and so will probably not progress any further. But it has certainly made me rethink how things could be done.


www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Mon, 6 Feb 2023 at 01:38, Viktor Zhuromskyy @.***> wrote:

Hi Viktor,

I am not sure what you mean. I think AB is easier than MyBible and also more intuitative. Is this what you are trying to do? https://youtu.be/PXdvFRLGcAA

In brief:

  1. Click once on a verse to show the verse action dialog
  2. Click 'Bookmark+' button.
  3. That's it. However, if you want to label it with a category, you can then use recent labels or create new ones from the dialog.
  4. You can then add a note by dismissing that label dialog and pushing the edit button.

I personally pefer this over the long-press option that I use in MyBible. But I am not overly familiar with MyBible so maybe there is an easier way to do it there.

Hello, yes, I do want to do similar thing to what is implemented in And Bible, but it is cumbersome and cluttered action. In MyBible highlighting and underlying, as well as removal of the colored selection is implemented so easily that you spend mere seconds vs minutes as in And Bible.

On top of that, in my modules the highlighting feature does not work. Here is YouTube video link to the screencast, but in Russian. https://youtu.be/m7W5L5tQGuc

— Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/2501#issuecomment-1418241022, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJXXI2QUAQ3XQVIHUNLWV73EHANCNFSM6AAAAAAURUTUIA . You are receiving this because you commented.Message ID: @.***>

viktor-zhuromskyy commented 1 year ago

OK, thanks for the video. That was helpful. I hadn't found that method of highlighting in MyBible. I had only ever used the Bookmark button. I can see what you mean that you can highlight sections in seconds. After I make the selection, I can do the same in AndBible in about 5 secs :) But I understand that the workflow for highlighting in MyBible is very simple, and once I found it, very easy. The problem I see with the MyBible quick underline/highlight is that it does not seem to link to a label/category. In AB, every bookmark has a label. I personally never bookmark without assigning a useful label. You could achieve much the same by creating labels called Green, Blue, Red etc and adding them as favourite labels. But it is one extra click for each highlight and the workflow is not as nice as MyBible. However, adding highlighting without useful labels is not really what AB is trying to do. When it comes to labelling a verse or selection, I think AB is superior to MyBible in most (every?) way. But again, I havent used MyBible much so that assessment may be premature. I think the biggest difficulty in incorporating the MyBible method is that we manage document windows very differently. The windowed approach in AB is very good and I think superior to MB. Back to the quick highlight request, although I like it alot, it is beyond my programming skills to implement. And I suspect Tuomas is not convinced of its need and so will probably not progress any further. But it has certainly made me rethink how things could be done. ___ [www.TenOutOfTen.org](http://www.TenOutOfTen.org*) https://www.TenOutOfTen.org @. (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar) On Mon, 6 Feb 2023 at 01:38, Viktor Zhuromskyy @.> wrote: Hi Viktor, I am not sure what you mean. I think AB is easier than MyBible and also more intuitative. Is this what you are trying to do? https://youtu.be/PXdvFRLGcAA In brief: 1. Click once on a verse to show the verse action dialog 2. Click 'Bookmark+' button. 3. That's it. However, if you want to label it with a category, you can then use recent labels or create new ones from the dialog. 4. You can then add a note by dismissing that label dialog and pushing the edit button. I personally pefer this over the long-press option that I use in MyBible. But I am not overly familiar with MyBible so maybe there is an easier way to do it there. Hello, yes, I do want to do similar thing to what is implemented in And Bible, but it is cumbersome and cluttered action. In MyBible highlighting and underlying, as well as removal of the colored selection is implemented so easily that you spend mere seconds vs minutes as in And Bible. On top of that, in my modules the highlighting feature does not work. Here is YouTube video link to the screencast, but in Russian. https://youtu.be/m7W5L5tQGuc — Reply to this email directly, view it on GitHub <#2501 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJXXI2QUAQ3XQVIHUNLWV73EHANCNFSM6AAAAAAURUTUIA . You are receiving this because you commented.Message ID: @.***>

Yes, I agree. Assigning label to any highlight of a text is a win-win, but a bit time consuming after you get used to that.

Are you guys Linux people?

viktor-zhuromskyy commented 1 year ago

I really love MyBible, but the way how I was treated by the MyBible developers is aweful. So, from now on I am going to flood you with feature requests if you do not mind. As soon as on my side I announce AndBible support for my modules you are getting thousands of Russian and Ukrainian speaking users. LOL

agrogers commented 1 year ago

If AB didn't exist I would choose MyBible. It seems MB has a lot more features than AB. A good example would be the search options - there are so many in MB.

New features are added slowly to AB - not enough developers or time

Tuomas is a Linux guy. I'm not.

On Tue, 7 Feb 2023, 6:12 am Viktor Zhuromskyy, @.***> wrote:

I really love MyBible, but the way how I was treated by the MyBible developers is aweful. So, from now on I am going to flood you with feature requests if you do not mind. As soon as on my side I announce AndBible support for my modules you are getting thousands of Russian and Ukrainian speaking users. LOL

— Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/2501#issuecomment-1419953159, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJX6VYP3HWRZ5YCWWZTWWGD75ANCNFSM6AAAAAAURUTUIA . You are receiving this because you commented.Message ID: @.***>

viktor-zhuromskyy commented 1 year ago

If AB didn't exist I would choose MyBible. It seems MB has a lot more features than AB. A good example would be the search options - there are so many in MB. New features are added slowly to AB - not enough developers or time Tuomas is a Linux guy. I'm not. On Tue, 7 Feb 2023, 6:12 am Viktor Zhuromskyy, @.> wrote: I really love MyBible, but the way how I was treated by the MyBible developers is aweful. So, from now on I am going to flood you with feature requests if you do not mind. As soon as on my side I announce AndBible support for my modules you are getting thousands of Russian and Ukrainian speaking users. LOL — Reply to this email directly, view it on GitHub <#2501 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJX6VYP3HWRZ5YCWWZTWWGD75ANCNFSM6AAAAAAURUTUIA . You are receiving this because you commented.Message ID: @.>

Problem with MB I face is their proprietary dictatorship.

tuomas2 commented 1 year ago

I really love MyBible, but the way how I was treated by the MyBible developers is aweful. So, from now on I am going to flood you with feature requests if you do not mind. As soon as on my side I announce AndBible support for my modules you are getting thousands of Russian and Ukrainian speaking users. LOL

Feature requests are welcome, but nobody is working here fulltime (time varies a lot and is often very limited, but my goal is to work 1 day per week) and we developers must find our motivation somehow to do things on our free time, thus not all requests are fulfilled. So in brief: we do what we like to do the most for the project.

But good quality PR's are quite likely accepted, and that's the idea of Open Source that everyone has possibility to affect with their own effort how the app looks in the future..

What comes to bookmarking/underlining, if a good proposal of UI/UX improvement is given (Andrew has made excellent proposals in the past), that retains existing functionality and flexibility but makes it just better (with fewer clicks etc), I'm open for it (but not promising anything still). Personally I'm happy with the way bookmarks/labels work in AB. I have not really tried how the feature works in MB but at least it's not super intuitive as I didn't even figure out that the feature exists by exploring the app briefly...

BTW since when did they introduce highlighting feature? I would like to exclude the possibility of GPL violation of our highlighting code :-)

viktor-zhuromskyy commented 1 year ago

I really love MyBible, but the way how I was treated by the MyBible developers is aweful. So, from now on I am going to flood you with feature requests if you do not mind. As soon as on my side I announce AndBible support for my modules you are getting thousands of Russian and Ukrainian speaking users. LOL

Feature requests are welcome, but nobody is working here fulltime (time varies a lot and is often very limited, but my goal is to work 1 day per week) and we developers must find our motivation somehow to do things on our free time, thus not all requests are fulfilled. So in brief: we do what we like to do the most for the project.

But good quality PR's are quite likely accepted, and that's the idea of Open Source that everyone has possibility to affect with their own effort how the app looks in the future..

What comes to bookmarking/underlining, if a good proposal of UI/UX improvement is given (Andrew has made excellent proposals in the past), that retains existing functionality and flexibility but makes it just better (with fewer clicks etc), I'm open for it (but not promising anything still). Personally I'm happy with the way bookmarks/labels work in AB. I have not really tried how the feature works in MB but at least it's not super intuitive as I didn't even figure out that the feature exists by exploring the app briefly...

BTW since when did they introduce highlighting feature? I would like to exclude the possibility of GPL violation of our highlighting code :-)

The MB code is close source. I do not know what is their code License. The highlighting feature in MB is so old as my gray hair.

What I was thinking is introducing the same idea of text highlighting as the one existing in MB, BWT on top of the one you already have. Both approaches have pros and cons, but offering simple and super fast approach to highlighting and underlying (parts of) texts as it is MB will be win-win thumbs up feature in AB.

tuomas2 commented 1 year ago

The MB code is close source. I do not know what is their code License. The highlighting feature in MB is so old as my gray hair.

Ok then probably no need for further investigations. That's my point: closed source code should not use GPL code. But because it is JS it might be possible to check if the code is used.

tuomas2 commented 1 year ago

wont fix