AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
588 stars 195 forks source link

When reading a book, invoking speech causes the display of legacy settings... #260

Closed bvahedy closed 5 years ago

bvahedy commented 5 years ago

When reading a book or dictionary, e.g. Josephus, ISBE, trying to invoked speak from the menu displays the old speak settings. Pressing play doesn't do anything.

tuomas2 commented 5 years ago

When reading a book, e.g. Josephus, trying to invoked speak from the menu displays the old speak settings.

Legacy settings are OK because new tts code was written specifically for bible documents, whereas old system is more general and can be used for commentaries and general books.

Pressing play doesn't do anything.

Can't reproduce. Tried with "BabtistConfession1689" -> Foreword and it started speaking fine.

bvahedy commented 5 years ago

Ok, after doing a clean install, it works as you described, but I have to have a check in the box for "queue" in the speak settings for it to speak. It's that normal?

On Tue, Jan 29, 2019, 10:43 AM Tuomas Airaksinen <notifications@github.com wrote:

When reading a book, e.g. Josephus, trying to invoked speak from the menu displays the old speak settings.

Legacy settings are OK because new tts code was written specifically for bible documents, whereas old system is general.

Pressing play doesn't do anything.

Can't reproduce. Tried with "BabtistConfession1689" -> Foreword and it started speaking fine.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/260#issuecomment-458657919, or mute the thread https://github.com/notifications/unsubscribe-auth/AsQYsXG5dTrTyOkBLG4aNcsBvq4YY621ks5vIJZQgaJpZM4aYpcn .

bvahedy commented 5 years ago

I'm closing this issue, since it is supposed to behave this way.