search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
603 stars 199 forks source link

Epub has white background in dark mode #2709

Closed timbze closed 1 year ago

timbze commented 1 year ago

https://www.monergism.com/thethreshold/sdg/owen/An%20Exposition%20of%20the%20Epistle%20to%20-%20John%20Owen2.epub

Screenshot from 2023-08-15 07-24-45

Bug was found on AndBible version Build 719-beta

tuomas2 commented 1 year ago

Some epub files change background with CSS. We can override that setting, but not sure if that can be done in such a way that it does not break other custom css.

tuomas2 commented 1 year ago

I noticed that same thing when trying Spurgeon Sermons epub from monergism.com.

timbze commented 1 year ago

One problem is that text is also white then.

We can override that setting, but not sure if that can be done in such a way that it does not break other custom css

I don't know exactly how it works, but I'm thinking it will have to be overridden for epubs. When do we need "epub set" background colors? We just want the text with html tags etc right?

timbze commented 1 year ago

This seems to be fixed in 721-beta