search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
592 stars 197 forks source link

MyBible modules of non-KJVA versification do not display all verses #2747

Open tuomas2 opened 1 year ago

tuomas2 commented 1 year ago

https://support.andbible.org/scp/tickets.php?id=1976

tuomas2 commented 1 year ago

That's because verses 8-9 are not part of KJVA versification.

tuomas2 commented 1 year ago

When determining VerseRange for chapter, for MyBible modules, should check the module itself which is the last verse of the chapter.

tuomas2 commented 1 year ago

I was trying to solve this in #2826.

JSword really wants to use versifications for this. I tried even ignoring versification in JSword (JSWord ba8f6afe24059cf43f84aaf93acd486e27acb5a1) but looks like it is not the way to go.

Way to go would be to create unique Versification for each MyBible document, read last verses from db and register v11n with Versifications.instance().register().

tuomas2 commented 1 year ago

It's not really "correct" for JSWORD to use versifications for this actually. There could be (also in standard SWORD) modules verses that are outside of versification boundaries, and those should be displayed nevertheless. So perhaps JSword should be fixed... as far as I know libSword does not do the same.

tuomas2 commented 1 year ago

Work estimate: 1 day.