AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
588 stars 195 forks source link

Make it easier to enable morphological codes #3034

Open Screwtapello opened 10 months ago

Screwtapello commented 10 months ago

Is your feature request related to a problem? Please describe. I wanted to look at morphological codes in AndBible.

After a lot of messing around, I eventually figured out that the "Greek letters" toolbar button is completely separate from the "Strongs numbers" items in the "three vertical dots" menu and in the "All Text Options" submenu. The "Morphological codes" option can only be toggled when Strongs numbers are enabled from the "three vertical dots" menu or the "All Text Options" submenu, not when they are enabled from the "Greek letters" toolbar button.

Describe the solution you'd like Instead of a "Strongs Mode" setting between "Off, Links, Text and Links", have an "Annotations" choice:

The "Greek letters" toolbar button and the "All Text Options" submenu can still be independent of each other, I assume that separation is there for a reason.

When showing links rather than "text and links", AndBible should probably always show all the available results from all the configured lemma and morphology dictionaries, rather than configuring which options they want to see. The user can scroll the results, so there's not the same pressure for conciseness that there would be in "Text and Links" mode.

Describe alternatives you've considered

agrogers commented 10 months ago

The problem you have hit is related to Workspace settings and window settings. The three dot menu configures the workspace settings (identified by the gray workspace overlay icon). They apply to new windows and also to existing windows that have the same setting as the workspace.​As soon as a user changes a window setting the three dot menu stops working for that setting.

I​can see why it is complicated for this particular setting. The concept of default workspace settings for morp codes doesn't apply well.

Perhaps indenting the morp setting might resolve part of the problem. But the confusion between workspace and window setting is harder to make clear.

Thanks for your suggestions.

On Fri, 10 Nov 2023, 19:38 Screwtapello, @.***> wrote:

Is your feature request related to a problem? Please describe. I wanted to look at morphological codes in AndBible.

  • I installed the KJVA translation and the Robinson's Morphological Analysis Codes dictionary
  • I enabled the dictionary in the "Robinson Greek Morphology" section of the application preferences
  • I went to Matthew 1:1
  • I switched to the KJVA translation
  • I went to the "three vertical dots" menu and there wasn't an option to enable Morphology, so I went to "All Text Options" at the bottom of the list
  • The "Morphological codes" option was turned off, and disabled so I couldn't turn it on
  • I double-checked I was using the KJVA, and I had all the required modules installed and enabled
  • I wondered if the morphological codes might be linked to Strong's codes, so I tapped the "Greek letters" toolbar button to turn them on
  • Still no morphology option in the "three vertical dots" menu, so I went to "All Text Options"
  • "Morphological codes" was still turned off and disabled

After a lot of messing around, I eventually figured out that the "Greek letters" toolbar button is completely separate from the "Strongs numbers" items in the "three vertical dots" menu and in the "All Text Options" submenu. The "Morphological codes" option can only be toggled when Strongs numbers are enabled from the "three vertical dots" menu or the "All Text Options" submenu, not when they are enabled from the "Greek letters" toolbar button.

Describe the solution you'd like Instead of a "Strongs Mode" setting between "Off, Links, Text and Links", have an "Annotations" choice:

  • Appearance:
    • ( ) Off
    • ( ) Links
    • ( ) Text and Links
  • When showing text, include:
    • Strongs numbers
    • Lemmas
    • Morphological codes

The "Greek letters" toolbar button and the "All Text Options" submenu can still be independent of each other, I assume that separation is there for a reason.

When showing links rather than "text and links", AndBible should probably always show all the available results from all the configured lemma and morphology dictionaries, rather than configuring which options they want to see. The user can scroll the results, so there's not the same pressure for conciseness that there would be in "Text and Links" mode.

Describe alternatives you've considered

  • Keeping the "Greek letters" toolbar button and the "All Text Options" submenu in sync would have helped me figure things out sooner
    • I assume that separation is there for a reason
  • Having more explanatory text beneath the "Morphological codes" option in the "All Text Options" submenu might help
    • you'd need a lot of text to explain all the possible reasons why the option might be disabled (missing dictionary module, modules disabled, no morph codes in the current text, the relationship between the "Greek letters" option and the "All Text Options" option...) and it would be a lot of work
  • Have the "Morphological codes" option enabled whenever viewing a module that includes them
    • Turning the option on would seem to do nothing if "Strongs Mode" was not set to "Text and Links", or if viewing a Bible that only has codes in the New Testament and you're looking at the Old Testament.

— Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/3034, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJTF6DXQ4TF3ABO6BZ3YDYRNHAVCNFSM6AAAAAA7GE5WEOVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DONJZGY2DGMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>