search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
550 stars 193 forks source link

Remove "Find in Bible" context menu action (form other apps) #3119

Open tuomas2 opened 6 months ago

tuomas2 commented 6 months ago

Causes more harm than benefit. I have seen some people hating it even.

Related: https://support.andbible.org/scp/tickets.php?id=2330

tuomas2 commented 6 months ago

Created poll in Telegram

tuomas2 commented 6 months ago

Related crash (in above mentioned ticket)

Exception:
java.lang.ArrayIndexOutOfBoundsException: length=0; index=0
at org.crosswire.jsword.book.sword.SwordUtil.decodeLittleEndian32(SwordUtil.java:197)
at org.crosswire.jsword.book.sword.TreeKeyIndex.getOffset(TreeKeyIndex.java:118)
at org.crosswire.jsword.book.sword.TreeKeyIndex.getFirstChild(TreeKeyIndex.java:88)
at org.crosswire.jsword.book.sword.GenBookBackend.doReadIndex(GenBookBackend.java:210)
at org.crosswire.jsword.book.sword.GenBookBackend.readIndex(GenBookBackend.java:177)
at org.crosswire.jsword.book.sword.SwordGenBook.activate(SwordGenBook.java:76)
at org.crosswire.common.activate.Activator.activate(Activator.java:51)
at org.crosswire.jsword.book.sword.SwordGenBook.checkActive(SwordGenBook.java:247)
at org.crosswire.jsword.book.sword.SwordGenBook.getKey(SwordGenBook.java:200)
at net.bible.service.history.HistoryManager.restoreFrom(HistoryManager.kt:103)
at net.bible.android.control.page.window.WindowRepository.loadFromDb(WindowRepository.kt:359)
at net.bible.android.control.page.window.WindowRepository.initialize(WindowRepository.kt:104)
at net.bible.android.control.page.window.WindowRepository.getActiveWindow(WindowRepository.kt:117)
at net.bible.android.control.page.window.WindowControl.getActiveWindow(WindowControl.kt:75)
at net.bible.android.control.page.window.WindowControl.getActiveWindowPageManager(WindowControl.kt:70)
at net.bible.android.control.search.SearchControl.getCurrentPassageDocument(SearchControl.kt:196)
at net.bible.android.control.search.SearchControl.currentDocumentContainsNonScripture(SearchControl.kt:199)
tuomas2 commented 6 months ago

I am not yet sure if it can be made an option (it is declared in android manifest (PROCESS_TEXT intent for SearchResults activity)). By far easiest would be just remove it if it does not bring real value to any users, but if it is really useful even to 1% of users, it might be good idea to try to keep it.