AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
587 stars 194 forks source link

AndBible should ask on start for the permission for Bible links be opened in itself. #3213

Open mcepl opened 7 months ago

mcepl commented 7 months ago

Is your feature request related to a problem? Please describe. I have a web application https://hesla.ceplovi.cz/ which shows Czech and German Losungen/Watchwords for every day. Originally, I was linking with Bible verses to https://www.crosswire.org/study/ , but that site is completely impossible to use on the phone, so I was very glad when you have developed Bible linking for And Bible. Thank you!

Unfortunately, the usability of this for newcomers is horrific. I have now users who are complaining that nothing works, because obviously they have to switch the linking on.

Describe the solution you'd like Instead of Settings/Open Bible Links in AndBible (or it could be actually preserved, if the user later wants to switch it off), AndBible would on start ask for the first time for permission in the same way when other applications ask for permission to access calendar/addressbook/file system/camera/etc.

tuomas2 commented 5 months ago

As far as I remember, the feature should be now enabled by default when app is installed from Google Play.

(note to myself: that's because we have autoVerify=true in manifest and https://read.andbible.org/.well-known/assetlinks.json in place)

tuomas2 commented 5 months ago

Maybe also for F-droid version actually, as there are 2 fingerprints in assetlinks.json

mcepl commented 5 months ago

Filed the ticket at https://gitlab.com/fdroid/fdroiddata/-/issues/3242

tuomas2 commented 5 months ago

Actually I didn't mean that the problem would be in F-droid packaging. And even if it was, I think F-droid developers could not do anything about it.

tuomas2 commented 5 months ago

~BTW autoVerify works on Android6+ devices (https://developer.android.com/training/app-links/verify-android-applinks#web-assoc), are your users having recent mobile phones?~ Nevermind, AndBible is only for Android 6+ devices thes days.

tuomas2 commented 5 months ago

Tested installing AndBible with F-droid to a device that does not have AndBible before. Feature was automatically enabled, i.e. autoVerification seem to work for F-droid builds too.

mcepl commented 5 months ago

OK, then I don't understand something. I have AndBible from F-Droid (version 5.0.805) and when I go in my Firefox on Android (Fennec 124.2.0 from F-Droid as well) to https://github.com/AndBible/and-bible/wiki/Bible-links and click on https://read.andbible.org/1Sam.1.2?v11n=KJV I get the error page “You need to install AndBible for this link to work”. What do I do wrong?

tuomas2 commented 5 months ago

Does Firefox open other deeply linked apps correctly? I haven't tried Firefox on Android.

mcepl commented 5 months ago

It did work, like in January or so. And let's say, yes, the phone link on this page works just fine.

tuomas2 commented 5 months ago

Can you try if this link: AndBible in Google Play opens in Google Play app, when clicking the link from Firefox? It should.