search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
593 stars 197 forks source link

MySword module rendering issues #3326

Open tuomas2 opened 1 month ago

tuomas2 commented 1 month ago

Title: Issues with Strong's Number Rendering in .mybible Files on AndBible

Summary:
User reports multiple issues related to loading and rendering Strong's numbers using a .mybible file in the AndBible app. The issues range from loading errors to mis-rendering of Strong's numbers, extra spaces in specific cases, and differences between in-app downloaded modules and imported ones.

Key Points:

  1. Failed to load a .mybible.zip file directly into AndBible; it required manual extraction of the .mybible file.
  2. Strong's numbers are missing or mis-rendered, especially in verses with consecutive Strong's tags.
  3. Extra spaces appear between words and punctuation, especially after tags in some verses.
  4. Specific issues with Strong's rendering in Gen 1:4, Gen 25:7, and Gen 3:20 (correct behavior).
  5. Copy-pasting from app lacks spacing between verse numbers and text.
  6. Hyphenation does not work for manually loaded .mybible files, unlike in-app downloaded modules.

Original Message:

  1. Downloaded file from https://mysword-bible.info/download/getfile.php?file=akjvstrong.bbl.mybible.zip
  2. Attempted to load the zip file to AndBible using "Load Documents From Files" menu—failed with error "File does not contain a valid Sword module". (It might be nice to process .mybible.zip files also.)
  3. Extracted akjvstrong.bbl.mybible from the zip file and successfully loaded the .mybible file to AndBible using "Load Documents From Files" menu.
  4. Opened Gen 1:1 with Strong's numbers turned on.
  5. Strong's numbers are not rendered for the .mybible module, but they are rendered for the KJV version downloaded within the app.
  6. Noticed that a blank space is rendered where a number should be between a word and punctuation following the Strong's number tag. Gen 1:4 is a good example, with a comma, colon, and period, all preceded by (in the SQLite file) a Strong's number tag.
  7. Noticed rendering of Strong's numbers fails in verses containing two or more consecutive tags, but works fine in verses without consecutive tags.
  8. Noticed a slightly different mis-rendering in Gen 25:7, where the extra space appears close to but not at the position of the missing number. "Abraham's" is rendered improperly as "Abraham' s" with a space between the apostrophe and the "s" instead of following the "s". Please test this verse to verify correct placement of the Strong's number. An example showing that the space between apostrophe and "s" only occurs when number rendering fails is Gen 3:20, where "his wife's" is correctly rendered "his wife's 802."
  9. Noticed that even for modules downloaded directly within the app, there is a lack of space between the verse number and text when copying and pasting.
  10. Noticed hyphenation works on modules downloaded within the app but does not work from .mybible modules loaded from a file.
  11. Noticed that the extra space preceding punctuation still appears even when Strong's numbers are disabled in the app. This only applies to verses with consecutive tags.

Summarized using Summarize @ ChatGPT

tuomas2 commented 2 weeks ago

The loading error is more of a feature request than a bug since the app does not claim to support zipped mybible format files.

Regarding hyphenation, I don't know if it is enabled or disabled by flags expected to be in modules. It is possible that some module types don't support it or that some specific modules have that feature disabled by the module author. I suspect that the hyphenation issue would not really be classified as a bug but more a possibly not yet implemented feature.