AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
579 stars 193 forks source link

Synchronization fails when moving the third window up by one verse... #473

Open bvahedy opened 4 years ago

bvahedy commented 4 years ago

to reproduce (beta build 325): With three windows open. Top window is esv Middle window is hisb Button window is wlc

When moving the top window the two lower windows synchronize. But when moving the bottom (wlc) window the top window moves to the wrong verse.

Expected result: When any of the windows are positioned to any verse the other windows should follow.

tuomas2 commented 4 years ago

Can't reproduce yet, though replaced wlc with WEB as I couldn't find WLC. Where can I obtain it?

Does it matter which bible passage you are trying or does it reproduce with any?

bvahedy commented 4 years ago

You can pick up the wlc from: https://1drv.ms/u/s!AgQrBUWnj0-jhRg1h7iX8T8a_a6i

This is all the modules I work with.

I was in Deuteronomy chapter 18 it does it pretty constantly. Try going to a book and chapter from the menu bar then slide up on the first window couple of verse, you will notice that synch is off on the two lower windows.

On Thu, Dec 19, 2019, 12:05 PM Tuomas Airaksinen notifications@github.com wrote:

Can't reproduce yet, though replaced wlc with WEB as I couldn't find WLC. Where can I obtain it?

Does it matter which bible passage you are trying or does it reproduce with any?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/473?email_source=notifications&email_token=ALCBRMMX3O5UFZUOP2LO3YLQZPHXVA5CNFSM4J5NUVT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHKYSLI#issuecomment-567642413, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCBRMITG6GNA3MS2SB6MN3QZPHXVANCNFSM4J5NUVTQ .

tuomas2 commented 4 years ago

I can now reproduce the issue, but scrolling with middle window rather than top window.

tuomas2 commented 4 years ago

I found out that there is super poor rendering performance on Android WebView in HISB module. I'm thinking this is caused by Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=428083. Hope it will be fixed soon in Chromium.

tuomas2 commented 4 years ago

Reproduce:

  1. Only one window with HISB is enough. (no css customization)
  2. Go to deut 8:1
  3. Scroll down few verses
  4. Actual: After few verses, it will show just white content. If you stop here and wait maybe 10 seconds, it will display more content. Expected: It should continue scrolling and show more stuff smoothly without delay.
bvahedy commented 4 years ago

Tuomas, this problem should be under a separate ticket unless you feel it is related to the synchronization issue.

On Fri, Dec 20, 2019, 9:18 AM Tuomas Airaksinen notifications@github.com wrote:

Reproduce:

  • Only one window with HISB is enough. (no css customization)
  • Go to deut 8:1
  • Scroll down few verses
  • Actual: After few verses, it will show just white content. If you stop here and wait maybe 10 seconds, it will display more content.
  • Expected: It should continue scrolling and show more stuff smoothly without delay.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/473?email_source=notifications&email_token=ALCBRMPNR65KNKYODEPQ6S3QZT47TA5CNFSM4J5NUVT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHNRSJY#issuecomment-568006951, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCBRMMPKNM4VZBCEP7YUDDQZT47TANCNFSM4J5NUVTQ .

tuomas2 commented 4 years ago

Tuomas, this problem should be under a separate ticket unless you feel it is related to the synchronization issue.

Synchronization is a consequence of WebView hanging (because of Chrome bug). When it is hanging, it won't tell the current location, thus making synchronization not work.

So unless we can reproduce sync issue with some other (normally functioning) module, I think we can keep these together, as one is symptom of another.

tuomas2 commented 4 years ago

For the record, some screenshot from my profiling session

Selection_105