search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
579 stars 193 forks source link

Deleting bookmark fails #623

Open tuomas2 opened 4 years ago

tuomas2 commented 4 years ago
  1. Open 2 synced windows: FinSTLK and ESV
  2. In FinSTLK, go to psalm 21:2
  3. Create bookmark on psalm 21:2, on FinSTLK window
  4. Try to delete bookmark on ESV window (in there, same verse is Ps.21.1) -> delete action does not appear at all.
tuomas2 commented 4 years ago

delete action appears on ps.21.2. It looks like delete action does not take into account versification.

tuomas2 commented 4 years ago

To database, we save bookmarks by osisID and versification. But from database, it is not easy to look up verse with different versification.

I guess we should normalize database somehow (for example, save only ordinal in standard versification (KJV?)). Then fixing this would be easy. But now I'll postpone fixing this.

tuomas2 commented 4 years ago

Just noticed that My Notes seem to use NRSVA versification always (claiming that "NRSVA should contain most dc books and allow verse to be fetched").

net/bible/service/db/mynote/MyNoteDBAdapter.kt:199 (comment in getMyNoteDto)