search

AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
591 stars 197 forks source link

Create search index user friendliness #817

Open timbze opened 4 years ago

timbze commented 4 years ago

When searching module for the first time, this message comes up: An index is required to search. Create index for KJV? With option to either Cancel or Create

I doubt that it's a good idea to automatically create an index for each module automatically after install (e.g. I don't normally search in commentaries).

However, we could make the message more user friendly for people who have no idea what an index is, for example we could have a message something like: In order to search KJV, And Bible needs to do a one-time search index generation which may take a few minutes. With the options to simply "Cancel" or "Continue" (i.e. continue instead of create)

And then on "Continue" press, find window would open with generate status at bottom, but find criteria could already be entered. The search button would not become active until index generation is complete.

timbze commented 3 years ago
agrogers commented 3 years ago

We have changed the message about an 'index'. I think it is a little clearer.

I suggest we delay this one to after v3.4 release

tuomas2 commented 2 years ago
  • [ ] When creating index it shows this screen (what is visible has nothing to do with index creation, and it's not scrollable).

More specifically

agrogers commented 1 year ago

Is there any reason that these indexes cant be generated whenever a new document is included? How much space do the indexes consume? If it is not much i would just learn the indexing process in the background when the Bible is added.

tuomas2 commented 1 year ago

Maybe automatic background indexing could be done, optionally (setting to disable this should be there probably too). Notification is displayed to user while indexing takes place.

agrogers commented 1 year ago

A toast message and the general Android notifications are already implemented I think.

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Sat, 7 Jan 2023 at 15:26, Tuomas Airaksinen @.***> wrote:

Maybe automatic background indexing could be done, optionally (setting to disable this should be there probably too). Notification is displayed to user while indexing takes place.

— Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/817#issuecomment-1374419525, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJTWFP4FXL4THD2HBXDWREVS5ANCNFSM4QHNWDWQ . You are receiving this because you were assigned.Message ID: @.***>

tuomas2 commented 1 year ago

Yes.

timbze commented 1 year ago

Is there any reason that these indexes cant be generated whenever a new document is included? How much space do the indexes consume? If it is not much i would just learn the indexing process in the background when the Bible is added.

Maybe... Though I have a bunch of Bible versions but generally only want to search in 1. So I wouldn't want indexes to be created every time I download a Bible version... Might not be a big deal for most, not sure.

agrogers commented 1 year ago

If it happens in the background and doesnt take much space on the device then I dont really see a problem. I have heaps of versions too and very few of them I search. But it always bothers me when i do go to search and i have to wait a minute or two for the indexing to happen.

www.TenOutOfTen.org https://www.TenOutOfTen.org @.*** (+61) 0477 174 193 (Australia) (+95) 09 250018669 (Myanmar)

On Sat, 7 Jan 2023 at 17:36, Timmy Braun @.***> wrote:

Is there any reason that these indexes cant be generated whenever a new document is included? How much space do the indexes consume? If it is not much i would just learn the indexing process in the background when the Bible is added.

Maybe... Though I have a bunch of Bible versions but generally only want to search in 1. So I wouldn't want indexes to be created every time I download a Bible version... Might not be a big deal for most, not sure.

— Reply to this email directly, view it on GitHub https://github.com/AndBible/and-bible/issues/817#issuecomment-1374441071, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKGTJQYGBI3FOELGXXWCBLWRFE4LANCNFSM4QHNWDWQ . You are receiving this because you were assigned.Message ID: @.***>

Noitarud commented 1 year ago

Building for searching can be inconvenient when it stops you, if its a Bible and the search is still being built (including new install), and the user specifies the group of bible books (see idea ), •alter build sequence to finish search faster. In the case of a new install, start to build the search •while the user is tinkering with/gawking at his new install. I only rarely had ever searched first up, there is idle time (particularly when they start looking at the settings). There is idle time on the restore screen (can it be done •while user browses for files?) and •when downloading multiple objects, perhaps restart+recolour the progress bar for the index on the download screen, continue later the ones that don't make it.