AndBible / and-bible

AndBible: Bible Study
https://andbible.org
GNU General Public License v3.0
592 stars 197 forks source link

verse link of some dictionary strongs entry not clickable #896

Open JacobZy opened 3 years ago

JacobZy commented 3 years ago

Describe the bug Dictionary module AbbottSmithStrongs has some verses link for each strongs entry.but show as plain text.

Bug was found on And Bible version version 3.3.399#24411f9

To Reproduce Steps to reproduce the behavior:

  1. Go to download and install dictionary module AbbottSmithStrongs
  2. Click on 'choose document menu',choose AbbottSmithStrongs and open it
  3. Click top bar and input '00345' index number
  4. the dictionary window show the strongs entry content,but all bible verse link not clickable.
  5. also the entry text all without break, from xiphos we can see actually it can show more clearly as several paragraphs

Expected behavior The dictionary window show the strongs entry content, all bible verse link should show as hypertext and clickable. and show text with line break will make it more readable

Smartphone (please complete the following information):

Additional context

bvahedy commented 3 years ago

I believe this is a module issue. It's possible that Abbotts dict. is not using OSIS protocol for it's link format.

JacobZy commented 3 years ago

@bvahedy Actually this dictionary module Abbotts use TEI format other than OSIS. and I find ' At the moment OSIS does not have thorough support for complex dictionaries. For that reason we support TEI for dictionaries. ' description at the link:https://wiki.crosswire.org/DevTools:Modules. I think tt will be make the app more compatible if you add support for TEI format. Thanks!

bvahedy commented 3 years ago

One of the developers would have to look at this to see how major of a mod it would be.

tuomas2 commented 3 years ago

Probably will do this for 3.4. #888 will change the way links are processed anyway.

tuomas2 commented 3 years ago

Osis XML produced by JSword is garbage. Does any frontend show this properly? Need fix on JSword side if the module contains some sensible way to indicate links.

<div><title type="x-gen">00345</title> **   ἀνά-κειμαι    

  [in LXX:  I Es 4:10 ,  To 9:6   א  * ;]  

    in cl., as pass. of  ἀνατίθημ , to be laid up, laid:  Mk 5:40  Rec.  
    In late writers (cf. MM,  VGT , s.v.) =  κεῖσθαι, κατακεῖσθαι , to recline at table:  Mt 26:20 ; part.  ἀνακείμενος ,  Mt 9:10   22:10-11   26:7 ,  Mk 6:26   14:18   16:14 ,  Lk 22:27 ,  Jo 6:11   12:2   13:23 ,  28 .† 
   SYN. :  ἀνακλίνω ,  ἀναπίπτω , the latter denoting an act rather than a state and thus in  Jo 13:25  differing from  ἀνάκειμαι  (see.  Jo 13:23 ) by indicating a change of position.  
</div>
JacobZy commented 3 years ago

As I know.Xiphos on linux can show this module properly and its link be clickable.

tuomas2 commented 3 years ago

It could be also similar module error as in #689. Need to debug a bit further.

agrogers commented 3 years ago

I suggest we delay this one to after v3.4 release

tuomas2 commented 3 years ago

These issues are often result of broken module xml. I believe sword engine is more gracefully trying to intepret even broken xml, but JSword does not do that. We could try to see if there's something we could do on JSword, but solutions might not be pretty. Better idea is to fix the module(s).