search

AndInTheClouds / chordreader2

Search for, display, transpose and save chords on your phone, that you get from the interwebs. :notes:
GNU General Public License v3.0
33 stars 8 forks source link

Transitioning from Java to Kotlin #15

Open wtimme opened 1 year ago

wtimme commented 1 year ago

Hey @AndInTheClouds,

first off: Thanks for your effort! I only recently discovered the app and it has already helped me play with chords when making music with friends.

I noticed that the app is written in Java. What are your plans/ideas about moving to Kotlin? Would you be accepting pull requests for this?

Again, thanks for your effort!

AndInTheClouds commented 1 year ago

Hi wtimme,

firstly, this is just a hobby project and I'm not a professionel programmer. So time is rare and I only spend some time to have a tool for my actual hobby, make music with my friends ;) However, there are still a lot of bugs and nice to have more features to be integrated. I'm not familiar with Kotlin, only worked with Java. But in principle it should be no problem to mix both languages in a project according to e.g. https://developer.android.com/kotlin/add-kotlin So, we can have a try. Perhaps, we start with a less complex change? Or do you already revised/developed larger parts?

Regards andintheclouds

Am 7. Juni 2023 22:27:17 MESZ schrieb wtimme @.***>:

Hey @AndInTheClouds,

first off: Thanks for your effort! I only recently discovered the app and it has already helped me play with chords when making music with friends.

I noticed that the app is written in Java. What are your plans/ideas about moving to Kotlin? Would you be accepting pull requests for this?

Again, thanks for your effort!

-- Reply to this email directly or view it on GitHub: https://github.com/AndInTheClouds/chordreader2/issues/15 You are receiving this because you were mentioned.

Message ID: @.***>

wtimme commented 1 year ago

Thanks for your feedback! I have decided to introduce a first unit test (see #21), with the goal of first having things unit-tested and only then refactoring the code to Kotlin. Otherwise, I might brake existing functionality.

Please take a look at the open pull requests and let me know if there's anything I can help you with. I used to develop quite a lot for iOS and I am only getting started with Android.