search

AndInTheClouds / chordreader2

Search for, display, transpose and save chords on your phone, that you get from the interwebs. :notes:
GNU General Public License v3.0
31 stars 8 forks source link

No Ticket: Resolve problems reported by Android Studio #22

Closed wtimme closed 1 year ago

wtimme commented 1 year ago

Introduction

This branch resolves a lot of "problems" that were reported by Android Studio, for example unused code and best practices.

In order to see these problems (e.g. on master), open the project in Android Studio. From the project explorer, right-click on the directory that you would like to scan (e.g. "app") and select "Analyze > Inspect code...". Under the "Problems" tab, you will see a report with all the issues that were found.

The branch does not fix all of the issues, but a good bunch of them.

The main goal here is to have as little distraction as possible when reading/working with the code. A lot of the suggestions made by Android Studio are considered "Best Practices", so it makes sense to follow them.

I have tried to use small and atomic commits, which should make the review easier. (Rather than going through the combined Git diff, you could go through the changes commit by commit.)

How to test

Checkout this branch and deploy the app to your device (or run it in an emulator). The app should still be functioning as expected.

wtimme commented 1 year ago

I have just checked out this branch again, cleaned the project and build it again. It is running fine in the emulator (Pixel 4a API 30 (Android 11.0 Google APIs)).

@AndInTheClouds, I suggest we merge this branch and release a new version immediately afterwards. That way, we get early feedback and can fix things if needed. What do you think?

AndInTheClouds commented 1 year ago

Alright, I'll prepare a release tonight.

Am 15. Juni 2023 20:05:56 MESZ schrieb wtimme @.***>:

I have just checked out this branch again, cleaned the project and build it again. It is running fine in the emulator (Pixel 4a API 30 (Android 11.0 Google APIs)).

@AndInTheClouds, I suggest we merge this branch and release a new version immediately afterwards. That way, we get early feedback and can fix things if needed. What do you think?

-- Reply to this email directly or view it on GitHub: https://github.com/AndInTheClouds/chordreader2/pull/22#issuecomment-1593515028 You are receiving this because you were mentioned.

Message ID: @.***>