search

AndInTheClouds / chordreader2

Search for, display, transpose and save chords on your phone, that you get from the interwebs. :notes:
GNU General Public License v3.0
29 stars 5 forks source link

Parses ultimate guitar ads #37

Open joshpetit opened 1 year ago

joshpetit commented 1 year ago

Hey this app is awesome! One problem I have is that when getting tabs from ultimate guitar, it includes the video add text as well, here's a text copy of an example from a song (Broken Vessels Amazing Grace):

Key: G

[Intro]

Em   G

[Verse 1]

          Em
All these pieces
           G
Broken and scattered
         Em
In mercy gathered
           G
....

Powered By                                 10 Sec      5 Guitar Amps for Beginners That Are Actually Great             NextStay

    5 Guitar Amps for Beginners That Are Actually GreatNOW 
 PLAYINGULTIMATE GUITAR VIDEO BLOG  The Latest UpdatesNOW 
 PLAYING5 Hollywood Actors Who Are Into MetalNOW 
 PLAYING5 Cheap Guitars That Are Actually GreatNOW 
 PLAYING5 Albums Artists Regret They DidNOW 
 PLAYINGSwitching Between D and ENOW 
 PLAYING                                Arrow Left #1 Icon            Created with Sketch.                                                                                                  Arrow right #1 Icon            Created with Sketch.                                                                                                                                                                                                                            
[Chorus 1]

C
Amazing grace
    D
How sweet the sound
     Em                  C
That saved a wretch like me
       C
Ooh I once was lost
    D
But now I'm found
    Em              C
Was blind but now I see
...
wtimme commented 1 year ago

Thank you for creating an issue, @joshpetit!

I just tried to verified this using the link that you provided, but the ad was not part of the part text. My assumption is that ultimate-guitar.com shows this ad randomly, making the bug difficult to verify. Could you check again on your end and report back? Thanks in advance!

joshpetit commented 1 year ago

Thanks for taking a look at it. Try opening this link in your mobile browser with AdBlock turned off. I tried and get the advertisement

joshpetit commented 1 year ago

I completely understand if you've been busy, I want to push this in case you accidentally looked over it considering you responded so quickly initially. Thank you.

wtimme commented 1 year ago

Hey @joshpetit, thanks for pointing out the fact with the adblocker! That could be it.

To be perfectly honest, this is not at the top of my personal list of priorities (since I do not encounter these ads), but I'm happy to look over any pull request of yours, if you created one.

joshpetit commented 1 year ago

Thanks for your consideration