Keep the song screen on

AndInTheClouds / chordreader2

Search for, display, transpose and save chords on your phone, that you get from the interwebs. :notes:

GNU General Public License v3.0

31 stars 8 forks source link

Keep the song screen on #44

Closed tutiluren closed 2 months ago

tutiluren commented 9 months ago

In the screen where the song is displayed, keep the screen on. For other screens, the default timeout is used as always.

I was troubled when the song screen was first dimmed and then turned off while I was reading the chart. This PR addresses that by setting a Layout attribute that tells Android to not shut off the screen while the layout in question is in focus.

tutiluren commented 9 months ago

(Tested on Samsung S10+ and S23+.

Test protocol: https://mastodon.nu/@n/111840618106204378)

AndInTheClouds commented 8 months ago

Hi tutiluren, thanks for addressing this issue. But imo it's not a good idea to generally leave on the screen forever and drain battery to death in case you forget to switch off the screen manually. As there is a wake lock implementation for the song view while auto scroll I would revise the functionality to work also on plain viewing mode. Maybe the best approach would be to provide preference setting to let the user decide how long to leave on the screen.

Regards