AndWass / pushgen

Apache License 2.0
27 stars 4 forks source link

Add `step_by()` #53

Closed AndWass closed 3 years ago

AndWass commented 3 years ago

Closes #5

AndWass commented 3 years ago

Step by currently has performance issues in the "naive" but probably most common case. See #52

Benchmarks on my machine using 1.53 stable:

AndWass commented 3 years ago

Add stepping capability to SliceGenerator and benchmark both for regressions and compare with current .step_by

AndWass commented 3 years ago

Adding an advance method to base Generator trait with default implementation using run allows for same performance as for Iterator::for_each.

AndWass commented 3 years ago

Closed in favor of #64