search

Andargor / edce-client

Elite Dangerous Companion Emulator
MIT License
49 stars 13 forks source link

EDCE: more name diffs #4

Closed Andargor closed 9 years ago

Andargor commented 9 years ago

From a PM, gazelle

[QUOTE=gazelle]Hoi,

found some more name diffs:

[CODE]Type | JSON | DISPLAY ---------+-----------------------+--------------------- Category | "Narcotics" | "Legal Drugs" Category | "Slaves" | "Slavery" Item | "Bio Reducing Lichen" | "Bioreducing Lichen" Item | "Basic Narcotics" | "Narcotics" [/CODE]

Also the "Waste " has a space at the end, so I use strip() for all names.

[/QUOTE]

Andargor commented 9 years ago

Fixed.

Andargor commented 9 years ago

[QUOTE=gazelle][QUOTE=Andargor][QUOTE=gazelle]Hoi,

found some more name diffs:

[CODE]Type | JSON | DISPLAY ---------+-----------------------+--------------------- Category | "Narcotics" | "Legal Drugs" Category | "Slaves" | "Slavery" Item | "Bio Reducing Lichen" | "Bioreducing Lichen" Item | "Basic Narcotics" | "Narcotics" [/CODE]

Also the "Waste " has a space at the end, so I use strip() for all names.

cu, Bernd[/QUOTE]

Thanks! For future issues would you mind posting on github? [url]https://github.com/Andargor/edce-client/issues[/url][/QUOTE]

WARNING: You included the "Category" name diffs into the translation for items. That's wrong, because there is a item called "Slaves" which should not be translated to "Salvery"![/QUOTE]

Seriously, this should go on github! It makes things a lot harder for me, and other people can spot the errors. I'm coyping everything here in the issue.

Currently there are no categories included in the messages, and this needs to be discussed with the others.