Andarist / react-textarea-autosize

<textarea /> component for React which grows with content
http://andarist.github.io/react-textarea-autosize/
MIT License
2.22k stars 246 forks source link

row-property is a noop? #360

Open bigmistqke opened 1 year ago

bigmistqke commented 1 year ago

I just noticed in the example-site that the row-attribute is not doing anything:

Screenshot 2023-01-09 at 18 19 45

these are not 4 rows.

is this expected behavior? I understand that 'row' is a bit of an odd property in the first place when using an auto-growing textarea, but if it is a noop, then it would be better to just give a type-error imo.

btw I am making a port of react-textarea-autosize for solid

bigmistqke commented 1 year ago

either noop and type-error, or allow it and row={4} === minRow={4} maxRow={4} imo

Andarist commented 1 year ago

I'd probably remove this from the types (and from examples)