search

Andarist / stylis-plugin-extra-scope

Stylis plugin which adds extra scope to each produced CSS rule.
MIT License
23 stars 14 forks source link

Discussion: ":root" pseudo-class #12

Open rr-justin-hanselman opened 3 years ago

rr-justin-hanselman commented 3 years ago

Hello,

I have been using this plugin for a while and ran into an ambiguity with chakra-ui. Chakra-ui by default, converts all shared variables in js to css variables in a global file. These variables are under the ":root" pseudo class.

The feature-request/discussion:

Should ":root" be excluded from the scope prepending or should it be replaced with the scope completely?

From a correctness standpoint, replacement makes sense to me, however, certain ponyfills other scripts limit their scope to the general ":root" case. Part of me in inclined to have a configuration option like: "scopeRootPseudoClass" that can be configured.

Once this discussion is confirmed, I can go ahead and submit the PR if this is deemed useful!

Andarist commented 3 years ago

while you have faced this issue with :root, the same would happen for html, body and similar selectors. It seems impractical to cover all possibilities :thinking_face:

I'm not saying yes just yet - but let's try making a PR and we'll discuss this further then.