Andavin / Images

A custom image loading plugin for Spigot.
72 stars 33 forks source link

Handling of Images in missing worlds #57

Open RedstoneFuture opened 1 year ago

RedstoneFuture commented 1 year ago

Currently, you get a big warning message when an image was placed in a world that is no longer on the server, with startup. It would be good if instead you could get a short message in the console that contains 1. the name of the missing world and 2. the map ID.

WARN: https://pastebin.com/zGx0Mq1M

CloudeLecaw commented 1 year ago

interesting.... we have a server with many worlds and over 500 images on it. when i load a testaerver with the copy of the plugin in on a copy of one of the worlds, i just see a lesser number on serverstart of loaded images... and not an error meassage.. what type of server your using?

we use paper 1.19.2 together with the images plugin version 2.2.7, well first look in your error log ahows me your also using this Version.

so what plugin your using for multiple worls we uae the good old multiverse core in latest jenkns 870.

It would be good if instead you could get a short
message in the console that contains 1. the name
of the missing world and 2. the map ID.

i like the idea with the info of the meassage on startup. may it could be a bit extanteda bit. first it should be just an optional thing like a debugmode tbat can enabled and disabled on config. secound. the option to remove invailed located images from not existing worlds should be an optional option (may in config). i see reasons why this could be wanted + also reasons why this could be not wanted (if u often reuse your worlds or often use themed worlds, you dont want to replace images all times because the world was used aggain after a year...) so 3rd.. the extansion of the suggested Informationen...what whould bebusefull innmy eyes.

name the images that failed to load
  name of the world where it failed to load (this includes missing worldl
  the cords where the map should be located
  the mapID that it contains (the ID of the placed mapitems it tried to load)

this way you could look for the image and if the image could not be loaded in the world you could lool for the rason by looking , does world exist, is there something at this location, or removr the mapid files it used in the worldfolder. most plugins dont Carse about the mapid files and if you open the folder you found very fast over 10000 mapid files in the world.

RedstoneFuture commented 1 year ago

Sorry, I had forgotten to specify that: I use PaperMC 1.19.2 Build 200 with Images v2.2.7. And Multiverse-Core v4.3.1-b861 (currently the last official release). Since you don't get this WARN, it would be interesting to know why.

With the Map ID the admin can delete the Image from the images.db manually. (For my example case, I already figured it out and was able to delete it. But it was not quite easy.)

CloudeLecaw commented 1 year ago

could you tryout multiverse 870¿

since over a year multiverse only has Update on the jenkins and not on spigot. latest version on Jenkins is 4.3.2 Build 870 https://ci.onarandombox.com/job/Multiverse-Core/870/

RedstoneFuture commented 1 year ago

Same problem with Multiverse Build 870 on a clean test server.

Plugin config: https://pastebin.com/tgZQYMYp Warn: https://pastebin.com/7VKJp65H

CloudeLecaw commented 1 year ago

you unload the world while the plugin/server is running?...

I tried to start it x times now and it just results in the pictures not to load but without this error. hmmm nay only the devs knows why this issue accours