search

Andavin / Images

A custom image loading plugin for Spigot.
65 stars 30 forks source link

Added Support for 1.20.5 and 1.20.6 #85

Closed Kici33 closed 1 month ago

Kici33 commented 1 month ago

Changed version from 2.3.2 to 2.3.3 Added Support for 1.20.5 and 1.20.6 Updated specialsource-maven-plugin so it can utilize Java 21 when remapping the server files

CloudeLecaw commented 1 month ago

im confused.. the plgin version was allready 2.4.0...

resi23 commented 1 month ago

im confused.. the plgin version was allready 2.4.0...

Now I'm confused on the Spigot site the 2.3.2 is the latest https://www.spigotmc.org/resources/custom-images.53036/

CloudeLecaw commented 1 month ago

we didnt used the spigot version we use the vesion from the github that is marked as 2.4.0

i uploaded it for you so you can take a look https://file.io/HZ3CW1vPczYQ

resi23 commented 1 month ago

But here it is only 2.3.2 o.O

CloudeLecaw commented 1 month ago

to be honest i canteven renenmber who wrote this fork. it was uploaded by some user when we changed to 1.20.4 :3

resi23 commented 1 month ago

OK. So this PR works on 1.20.6 on Spigot but not on Paper because Paper removed the Craftbukkit relocation. This leads to the error that the Minecraft version cannot be parsed. Because you posted https://github.com/Andavin/Images/issues/84

CloudeLecaw commented 1 month ago

image i just see both have different size.. i wish i could renember who was giving away this 2.4.0 version so there are differences between these?

resi23 commented 1 month ago

The 2.3.2 is the one from the Spigot site? This Build don't have include this PR. The difference of 11 KB is explained by the package for 1.20.5/6. My version is 291 KB too. With this PR for 1.20.5/6 Bild_2024-05-23_110256408

resi23 commented 1 month ago

I found it. Andavin put it in the Spigot MC Discussion Thread wow