Open dpsanders opened 2 years ago
It would be great to make plot recipes for Plots.jl. You could maybe detect which plotting package is available and define code accordingly.
(But all that is necessary for the review is to add a note about this issue.)
plot recipes is the ideal way to do this. However when I tried the plotting with Plots.jl, I couldn't quite get it to look the way I liked, so I'd prefer to stick with PyPlot for now. What I have done is remove PyPlot as a dependence, and used Requires.jl. So that if you wish to plot, you need to using PyPlot
I still need to make note of this in the Documentation.
My default graphing library is
Plots.jl
, but PBA clashes with it:I'm not sure what is actionable here, but it should at least be mentioned in the README and docs.
Part of the review for the JuliaCon proceedings: https://github.com/JuliaCon/proceedings-review/issues/96