search

AnderWeb / discreteSeekBar

Apache License 2.0
2.11k stars 402 forks source link

Master #46

Closed d8ahazard closed 8 years ago

d8ahazard commented 9 years ago

Add setters for color values, getters for trackdrawable. Add option for custom track drawable. Rename listener to use "normal" name. Allow setting thumb and track height dynamically. Update sample project to reflect changes.

AnderWeb commented 8 years ago

We cannot just change some things like the listener interface name or method signatures without breaking current user's code. Is a thing to do only when really really necessary.

Also, I think pull requests should be feature targeted, having too many different features in a single pull request is a no-go from our part.

We've already added some of the sizing stuff (thumb size, trackHeight and scrubberHeight) in commit ddb4d1b3d3d0b61b54bdd2553e663f589529f097

If any other feature described here is needed, please feel free to open a new pull request with separate specific features.

Thank you!