Closed Anders429 closed 1 year ago
Merging #206 (9dee20e) into dev (0bb0ab9) will increase coverage by
0.61%
. The diff coverage is81.61%
.
@@ Coverage Diff @@
## dev #206 +/- ##
==========================================
+ Coverage 94.85% 95.47% +0.61%
==========================================
Files 89 89
Lines 15477 14147 -1330
==========================================
- Hits 14681 13507 -1174
+ Misses 796 640 -156
Impacted Files | Coverage Δ | |
---|---|---|
src/entities/mod.rs | 100.00% <ø> (ø) |
|
src/registry/contains/views/sealed.rs | 98.00% <ø> (ø) |
|
src/system/schedule/scheduler.rs | 100.00% <ø> (ø) |
|
src/system/schedule/sealed.rs | 100.00% <ø> (ø) |
|
src/system/schedule/stager.rs | 100.00% <ø> (ø) |
|
src/system/schedule/stages.rs | 100.00% <ø> (ø) |
|
src/system/schedule/task/sealed.rs | 100.00% <ø> (ø) |
|
src/system/schedule/mod.rs | 73.93% <33.60%> (-1.82%) |
:arrow_down: |
src/query/result/par_iter.rs | 83.14% <92.85%> (-2.15%) |
:arrow_down: |
src/archetype/mod.rs | 98.07% <100.00%> (ø) |
|
... and 10 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
The low patch coverage seems to be due to the amount of lines edited in schedule/mod.rs
. Those lines already have poor coverage because they are not intended to be run at all. Overall, this PR raises coverage :)
Fixes #192.
This reduces all of the many generic index parameters down to a single
Indices
parameter for all public traits and most public methods. The exceptions are with queries and systems, which still require 4 index parameters due to the four separate trait bounds. Future work could combine these trait bounds into a single trait (they only became separated because Resources and Entry views were introduced afterregistry::ContainsQuery
was already defined).This also addresses #188 a bit, replacing the iterators in
System::run()
andParSystem::run()
with a generic iteratorI
. There is still more that can be done on this front, possibly with replacing the entirequery_results
with a generic trait, but for now this is a great step forward.