search

Anders429 / word_filter

A Word Filter for filtering text.
Apache License 2.0
1 stars 0 forks source link

Stop storing repetition state #56

Closed Anders429 closed 3 years ago

Anders429 commented 3 years ago

Fixes #52.

This removes the need to store the state in the repetition field, instead tracking this during computation.

The benefit is huge spatial savings. Since each state is no longer tied to its previous state, the PDA graphs can be reduced tremendously in size during the minimization step. Additionally, removing the extra references decreases compilation time. This is a win all-around.

codecov-commenter commented 3 years ago

Codecov Report

Merging #56 (0cf2813) into 0.6.0 (0fdac39) will increase coverage by 1.62%. The diff coverage is 73.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##            0.6.0      #56      +/-   ##
==========================================
+ Coverage   84.46%   86.09%   +1.62%     
==========================================
  Files           9        9              
  Lines         631      683      +52     
==========================================
+ Hits          533      588      +55     
+ Misses         98       95       -3
Impacted Files Coverage Δ
src/pda.rs 74.23% <71.42%> (-7.68%) :arrow_down:
word_filter_codegen/src/pda.rs 88.13% <100.00%> (+13.69%) :arrow_up:
word_filter_codegen/src/state.rs 70.00% <100.00%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fdac39...0cf2813. Read the comment docs.