search

AndersDJohnson / firedux

:fire: :hatching_chick: Firebase + Redux for ReactJS
https://andersdjohnson.github.io/firedux/
MIT License
149 stars 12 forks source link

feat: adding signin with password #89

Closed katsumeshi closed 7 years ago

katsumeshi commented 7 years ago

try to restart #47 i would like to take this feature.

katsumeshi commented 7 years ago

any comments?

katsumeshi commented 7 years ago

remove the dist builds from the PR or regenerate for a clean merge?

I got it. i'm wondering though, couldn't we add dist builds into gitignore?

anyway, i'm bit confused about testing. i've tried to add the test case for logout to make sure working properly, however i got an error which is

Your API key is invalid, please check you have copied it correctly.

for now, i've put temporarily my own api key into ref.js

should i run the npm like this? npm test FIREBASE_API_KEY="something api key" or just put the key in ref.js?

AndersDJohnson commented 7 years ago

@katsumeshi Can you rebase so 9acd0904 commit message has fix: prefix? All commits should follow conventional commit standard.

AndersDJohnson commented 7 years ago

@katsumeshi Also we should rebase reword so 9acd0904c7de7baf374e5aef3a8420d63cd154be commit message follows AngularJS's conventions (e.g. fix: prefix).

katsumeshi commented 7 years ago

@adjohnson916 I think it's changed to proper commit message. let me know if there is any something wrong. Thank you

AndersDJohnson commented 7 years ago

@katsumeshi I have merged. I'll need to do another release at some point. I'd like to consider adding some tests first. Are you interested?

katsumeshi commented 7 years ago

@adjohnson916 Appreciate it . I'm glad to merge this branch. Yeah, I'd love to help here out whatever I can, let me know the details what you want me to do.

AndersDJohnson commented 7 years ago

@katsumeshi @DarrylD I've published to npm as 1.1.0.