search

Andersama / obs-asio

ASIO plugin for OBS-Studio
GNU General Public License v3.0
664 stars 43 forks source link

Crash on OBS 30.0.2 when device disconnects #147

Closed duncte123 closed 2 months ago

duncte123 commented 5 months ago

Plugin Version v3.2.0

Describe the bug When an ASIO device that is in use disconnects (simulated by unplugging it) due to any number of reasons the plugin crashes OBS.

Crash log: https://obsproject.com/logs/RsyQnlhGj0HVHmhJ OBS log: https://obsproject.com/logs/dOgbHDInPwItI1zf

To Reproduce Steps to reproduce the behavior:

  1. Use your favourite ASIO interface
  2. Have it disconnect (unplugging works for me)
  3. OBS crashes

Expected behavior I would expect the plugin to notice the device has disappeared and stop using it. After a connection to the device has been established again, I would expect the plugin to pick it up and continue like nothing happened.

Screenshots image image image image image image

Additional context I have a compressor and a limiter filter enabled for the source.

The USB connection on my audio interface is not the most reliable, if I accidentally touch the cable the device will disconnect for a few ms and continue working normally afterwards. WASAPI also struggles with this. Windows would still see the interface but will not allow any audio to go from and to it until I disconnect and reconnect it.

Andersama commented 2 months ago

When you replicate the error, can you check in your logs for a line that starts with Device Error. I don't believe I've ever intentionally unplugged my devices in testing.

duncte123 commented 2 months ago

2024-05-23 08-39-24.txt Crash 2024-05-23 08-39-48.txt

no specific line containing "device error", just a single line containing "device" at the end of the logs

Was able to reproduce the crash in the same way by simulating a device disconnect, using version v3.2.1f. Unplugging is the only way of reliably reproducing this unfortunately