Andersama / obs-asio

ASIO plugin for OBS-Studio
GNU General Public License v3.0
679 stars 43 forks source link

Do I need to use your obs-studio fork to build bassasio and can I use v14? #19

Closed arraybercov closed 5 years ago

arraybercov commented 5 years ago

I noticed your build directions ask to git clone obs-studio from your fork. Can I git clone directly from the obs github to get the latest version and can I use bassasio14? your link downloads the older bassasio13

Thanks! I'm new to building but hoping I can get this working.

pkviet commented 5 years ago

nope you don't need my obs-studio fork; you only need it if you want to build both obs and the plugin at the same time. You can also compile the plugin as a stand alone, it's explained in the instructions. The latter requires though that you have libobs library compiled so you might as well compile everything... I think I'll try to provide libobs lib in a deps folder to easen the compilation. I had not seen the new version of bassasio. I'll check it to see if it works.

pkviet commented 5 years ago

update: i've checked that you can drop in bassasio 1.4 without issues. I'll provide the obs lib and dll; this will make the compilation easier.

pkviet commented 5 years ago

update 2:

arraybercov commented 5 years ago

Hey Thanks for the info so far. I'm experimenting to get this working. If I build to plugin standalone using bassasio can I use that plugin with the installer download version OBS offers?

Trying to figure out why i'd even want to build OBS itself?

pkviet commented 5 years ago

sorry i forgot some steps in the wiki for stand-alone compilation:

arraybercov commented 5 years ago

Gotcha, do I still need to include this in the cmake variables since you now include it: "LIBOBS_INCLUDE_DIR (path) : location of the libobs subfolder in the source code of OBS Studio; for instance for me it is C:/obs-studio/libobs"

?

arraybercov commented 5 years ago

Ah sorry for all the questions. Right now, I generated obs-studio and am tryiing to generate the obs-asio plugin, but getting this WARNING. Should I ignore or am I doing something wrong? I believe that's the BASS_ASIO_LIB variable and i have it set to path. Should i change to file name? linking

When I open the project in VS2019 I don't see any "RelWithDeb" in the solution explorer to build.

arraybercov commented 5 years ago

I have the plugin working now! but not sure if I did anything wrong. A couple things I have to do different than your directions:

1) I had to put obs.lib in ...obs-studio\build\libobs\Debug instead of "RelWithDebInfo" because this exists nowhere for me in any of my builds or anywhere : /

2) I had to change the BASS_ASIO_LIB var to filepath because as my error in my last reply shows, i couldn't link to the library unless i actually selected it.

The only error i got while building the obs-asio plugin in VS2019 after those two steps is "MSB3073 The Command "Setlocal"

I think this is some kind of permissions error so I just ignored it and I found the .dll I needed in the build folder.

pkviet commented 5 years ago

On Sun, Jun 30, 2019, 10:14 La Gauche notifications@github.com wrote:

I have the plugin working now but now sure if I broke did anything wrong. A couple things I have to do different than your directions:

1.

I had to put obs.lib in ...obs-studio\build\libobs\Debug instead of "RelWithDebInfo" because this exists nowhere for me in any of my builds or anywhere : /

You have to create the folder

1.

I had to change the BASS_ASIO_LIB var to filepath because as my error in my last reply shows, i couldn't link to the library unless i actually selected it.

Not at my PC but you're probably right.

The only error i got while building the obs-asio plugin in VS2019 after those two steps is "MSB3073 The Command "Setlocal"

In vs studio in build menu, clean and rebuild

I think this is some kind of permissions error so I just ignored it and I found the .dll I needed in the build folder.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pkviet/obs-asio/issues/19?email_source=notifications&email_token=ACG2OTZJDOA63FG4ULSPX7TP5BTNXA5CNFSM4H4IPLZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4HRIQ#issuecomment-507017378, or mute the thread https://github.com/notifications/unsubscribe-auth/ACG2OT7CCD2PDLAYQMKKDHLP5BTNXANCNFSM4H4IPLZA .

arraybercov commented 5 years ago

I did create the "RelWithDebInfo" folder and put obs.lib in it, but if my memory serves me, VS gave me a build error saying it was looking for obs.lib here "obs-studio\build\libobs\Debug" but it could not find it. It was not aware of "RelWithDebInfo". Also the obs-asio build has three projects ALL_BUILD, obs-asio and ZERO-CHECK. There is no "RelWithDebInfo".

I remember a couple days ago i tried to to build OBS with the plugin and I did see that folder that's why I mention. I don't think it exists for me when just building the plugin.

pkviet commented 5 years ago

you're probably building obs-asio in debug, that's why. Try in RelWithDebInfo (release with debug info).

pkviet commented 5 years ago

on second thought, i think that providing the obs.lib and obs.dll files creates more confusion than it helps in the build instructions. So I've updated the instructions by requiring to compile obs-studio. This will be simpler for setting the paths. Sorry about this back and forth.

pkviet commented 5 years ago

Try to catch me on discord. This will be easier. We have some misunderstandings here.

On Sun, Jun 30, 2019, 19:26 La Gauche notifications@github.com wrote:

I did create the "RelWithDebInfo" folder and put obs.lib in it, but if my memory serves me, VS gave me a build error saying it was looking for obs.lib here "obs-studio\build\libobs\Debug" but it could not find it. It was not aware of "RelWithDebInfo". Also the obs-asio build has three projects ALL_BUILD, obs-asio and ZERO-CHECK. There is no "RelWithDebInfo".

I remember a couple days ago i tried to to build OBS with the plugin and I did see that folder that's why I mention. I don't think it exists for me when just building the plugin.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pkviet/obs-asio/issues/19?email_source=notifications&email_token=ACG2OTY5Y2SNCNJXCMH3G7DP5DUFXA5CNFSM4H4IPLZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY4QIBA#issuecomment-507053060, or mute the thread https://github.com/notifications/unsubscribe-auth/ACG2OTYYG5QJER2FS73GEMLP5DUFXANCNFSM4H4IPLZA .

pkviet commented 5 years ago

closing since the user managed to compile