search

Andersbakken / rtags

A client/server indexer for c/c++/objc[++] with integration for Emacs based on clang.
http://www.rtags.net
GNU General Public License v3.0
1.83k stars 252 forks source link

Not possible to use ac-rtags without error/warning decorations #1247

Closed jmalmari closed 5 years ago

jmalmari commented 5 years ago

Describe the bug Enabling rtags auto complete also enables some more buffer invasive error and warning decorations. I think it does this as a side(?) effect of running rtags-diagnostics in ac-rtags.el.

To Reproduce

  1. (require 'ac-rtags) (setq-default ac-sources '(ac-source-rtags))
  2. Visit rtags indexed C++ file with auto-complete on
  3. Add invalid c++ and save
  4. See bright red decorations

Expected behavior I'd expect to see only completions - not errors and warnings.

Environment:

Additional context Despite extra decoration, the completion itself works. The rtags-find-symbol-at-point etc also works. I use flycheck clang checker for errors and warnings.

jmalmari commented 5 years ago

For me it's enough to just remove this rtags-diagnostics call: https://github.com/Andersbakken/rtags/blob/29d3ee6ec1d8c9c1895fcab0c9887a8f286c6ed6/src/ac-rtags.el#L139

Then I have rtags auto-complete working without the errors & warnings part.