Andersbakken / rtags

A client/server indexer for c/c++/objc[++] with integration for Emacs based on clang.
http://www.rtags.net
GNU General Public License v3.0
1.83k stars 252 forks source link

rc exits with 1 under /tmp directory #860

Closed vladshablinsky closed 7 years ago

vladshablinsky commented 7 years ago

Hi, I'm trying to run rc with src directory under /tmp directory.

$ tree /tmp
/tmp
└── src
    ├── README
    └── foo.c
$ cat /tmp/src/foo.c
void zaphod() {
}

void beeblebrox() {
  zaphod();
}
$ readlink /tmp
private/tmp
$ rdm -L log

And this step fails:

$ echo "clang -c /tmp/src/foo.c" | rc -c

But if I move the src somewhere else, it works fine. Any ideas on how to fix this? I'm running macOS 10.12.

Andersbakken commented 7 years ago

Heh. We actually explicitly avoid indexing things inside /tmp

I believe I added that to avoid things like autoconf tests getting indexed. I'll see if I can add an option to disable this behavior.

Anders

On Wed, Nov 23, 2016 at 3:46 AM, Uladzislau Shablinski < notifications@github.com> wrote:

Hi, I'm trying to run with src directory under /tmp directory.

$ tree /tmp /tmp └── src ├── README └── foo.c $ cat /tmp/src/foo.c void zaphod() { }

void beeblebrox() { zaphod(); } $ readlink /tmp private/tmp $ rdm -L log

And this step fails:

$ echo "clang -c /tmp/src/foo.c" | rc -c

But if I move the src somewhere else, it works fine. Any ideas on how to fix this? I'm running macOS 10.12.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Andersbakken/rtags/issues/860, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEdSqW_VmqhQfzpsSNXXhceVb1H_kstks5rA_1cgaJpZM4K6VQL .

dmakarov commented 7 years ago

@Andersbakken this seems to be a big issue. Since the version 2.3_1 released about a month ago, rtags hasn't been updated in Homebrew because the updated version doesn't pass the tests. The net result is that currently Homebrew version of rtags quickly becomes out of sync with the latest rtags emacs package, and renders rtags homebrew and emacs packages unusable, unless one is willing to install --HEAD version of rtags.

Andersbakken commented 7 years ago

Ah. Interesting. I actually have a switch for this already.

If you run:

$ rdm --help | grep exclude-filter

You can see the default exclude filter. Is there a simple way to modify homebrew's tests? I actually don't really have anything to do with the packaging of rtags in homebrew so I don't really know how to add a parameter. In short I would say that the homebrew test should pass:

$ rdm --exclude-filter ""

Maybe the whole filter isn't that useful but I think I had some problems where files that were part of configure time tests were indexed.

Anders

On Sun, Nov 27, 2016 at 2:21 AM, Dmitri Makarov notifications@github.com wrote:

@Andersbakken https://github.com/Andersbakken this seems to be a big issue. Since the version 2.3_1 released about a month ago, rtags hasn't been updated in Homebrew because the updated version doesn't pass the tests. The net result is that currently Homebrew version of rtags quickly becomes out of sync with the latest rtags emacs package, and renders rtags homebrew and emacs packages unusable, unless one is willing to install --HEAD version of rtags.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Andersbakken/rtags/issues/860#issuecomment-263114066, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEdSqA9jWyruiiDREldg_hQehFe9QaIks5rCVmtgaJpZM4K6VQL .

vladshablinsky commented 7 years ago

Thanks @Andersbakken! Maybe I should have dug the rdm help more. 🙂 Now the tests are fixed!

Andersbakken commented 7 years ago

There's a ton of non-obvious switches in there so I don't blame you :-)

Awesome. Thanks

Anders

On Mon, Nov 28, 2016 at 3:01 PM, Uladzislau Shablinski < notifications@github.com> wrote:

Closed #860 https://github.com/Andersbakken/rtags/issues/860.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Andersbakken/rtags/issues/860#event-874431033, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEdSkJhjVOg5xvLFMDdxZ0u6c71GAXoks5rC103gaJpZM4K6VQL .