Closed arian2ashk closed 3 years ago
@arian2ashk sorry for the delay, the code looks great. One idea do we need a new type for each compression type? (It's currently only static data any way?)
Couldn't we just have CompressionType
and then have static instances for Gzip and Brotli, this way we could even extend so that the configuration of compression algorithms could be defined in the configuration file.
If you think this is overkill we could just go with what you have done!
Closed due to no response.
@AnderssonPeter any thoughts on this PR?