AnderssonPeter / CompressedStaticFiles

asp.net core middleware to send compressed static files to the browser without having to compress on demand, also has support for sending more advanced image formats when the browser indicates that i has support for it.
Apache License 2.0
88 stars 18 forks source link

Added support for adding more compression types #18

Closed arian2ashk closed 3 years ago

arian2ashk commented 4 years ago

@AnderssonPeter any thoughts on this PR?

AnderssonPeter commented 4 years ago

@arian2ashk sorry for the delay, the code looks great. One idea do we need a new type for each compression type? (It's currently only static data any way?)

Couldn't we just have CompressionType and then have static instances for Gzip and Brotli, this way we could even extend so that the configuration of compression algorithms could be defined in the configuration file.

If you think this is overkill we could just go with what you have done!

AnderssonPeter commented 3 years ago

Closed due to no response.