search

AnderssonPeter / Hangfire.Console.Extensions

Makes it easier to use Hangfire.Console with .net core dependency injection
MIT License
79 stars 17 forks source link

Consider migrating from Hangfire.Console package to IdentityStream.Hangfire.Console #14

Closed rossknudsen closed 10 months ago

rossknudsen commented 1 year ago

Hangfire.Console seems to be abandoned and has been recently forked and republished under IdentityStream.Hangfire.Console with a number of improvements. Would you consider migrating to this package?

AnderssonPeter commented 1 year ago

Hi I'm aware of the fork, and will create 2 new packages that target the new fork when I get some time.

AnderssonPeter commented 12 months ago

@rossknudsen the work is more or less done, I'm just waiting for the permission to use the chosen name before I upload the packages to nuget.org

rossknudsen commented 11 months ago

Any luck with the above?

AnderssonPeter commented 11 months ago

@rossknudsen sadly I can't create a nugget with their company name in it, as nugget.org it self blocks this.. so for now I'm a bit unsure what name I should pick that would make sense..

rossknudsen commented 11 months ago

Would you just bump a major version for this package? Possibly go through a prerelease first?

AnderssonPeter commented 11 months ago

I'm not fond of that solution as it would force existing users to change a nugget to get the latest features.

rossknudsen commented 11 months ago

How about reaching out to the maintainers of IdentityStream.Hangfire.Console and asking them to fork this repo and release IdentityStream.Hangfire.Console.Extensions? Presumably that was the NuGet package you wanted to create.

AnderssonPeter commented 11 months ago

I asked for a API key restricted to only that package, but they didn't like that idea.

rossknudsen commented 11 months ago

I'm not fond of that solution as it would force existing users to change a nugget to get the latest features.

Not 100% sure what the issue is exactly. Presumably people are referencing this Nuget package directly in their projects. Most of the time people would target a specific version (e.g. 1.1.0) rather than a wildcard version. Under that assumption, they'd need to explicitly change their code to use the new version whatever increment you use (IMO a major version increment matches what IdentityStream team did).

I think updating this project (Hangfire.Console.Extensions) to point to a maintained dependency is a solid choice rather than trying to create another package.

jherbert commented 10 months ago

Agree with @rossknudsen here. A 2.0.0 release with a breaking change of removing Hangfire.Console and adding IdentityStream.Hangfire.Console dependency. Then call it out in the release notes.

AnderssonPeter commented 10 months ago

@rossknudsen @jherbert sorry for the huge delay, there are 2.0 packages on their way now that target IdentityStream.