AndiDittrich / NodeMCU-Tool

:wrench: Upload + Manage Lua files on NodeMCU
https://www.npmjs.com/package/nodemcu-tool
MIT License
310 stars 54 forks source link

added new vendorId, changed filtering logic #50

Closed alexandruantochi closed 5 years ago

alexandruantochi commented 6 years ago
AndiDittrich commented 6 years ago

hi @alexandruantochi ,

thanks for your contribution. to merge the code there are a few things which should be changed:

  1. please don't change the coding styles (whitespaces)
  2. don't remove the vendor-id comments, add them to the array
    
    // vendor a
    '0x0a',

// vendor b '0x0b'


3. the additional if clause shouldn't be necessary because indexOf(null) will always return **-1** (fixed array content)

```js
if (item.vendorId == null) {
alexandruantochi commented 6 years ago

Will do. I'm thinking of also introducing a 'upload whole directory contents' option, what's your opinion on that? Personally I upload multiple files at once and this would be faster than writing a list of files.

AndiDittrich commented 6 years ago

wildcards/globs are already implemented - just use nodemcu-tool upload dir/*