search

AndiDittrich / NodeMCU-Tool

:wrench: Upload + Manage Lua files on NodeMCU
https://www.npmjs.com/package/nodemcu-tool
MIT License
310 stars 54 forks source link

Support for NodeMCU-firmware 3.X #65

Closed marcelstoer closed 4 years ago

marcelstoer commented 4 years ago

As per https://stackoverflow.com/a/57845719/131929 the latest NodeMCU 2.2.x -> 3.0 upgrade broke the fetchDeviceInfo() function. node.info() now works differently as per https://nodemcu.readthedocs.io/en/latest/modules/node/#nodeinfo.

AndiDittrich commented 4 years ago

Hi @marcelstoer ,

the issue seems only be related to the nodemcu-firmware >= 2.x.

i will check if it's possible to add some other kind of "detection"

marcelstoer commented 4 years ago

the issue seems only be related to the nodemcu-firmware >= 2.x.

Yes. That's why I think the title of this issue is now wrong.

AndiDittrich commented 4 years ago

not really... nodemcu-firmware is on 2.2.1 which causes the issue..

marcelstoer commented 4 years ago

We are both right - kind of. As I said we upgraded to SDK 3.0 i.e. we snapped our dev branch back to master just 2d ago. However, the release tag and the notes are pending. Will have to do that later today.

The issue described here is not present in 2.2.1 but only in 3.0 that is currently on dev and master.

AndiDittrich commented 4 years ago

ok sry my fault.

AndiDittrich commented 4 years ago

fixed within the master branch - projected for 3.1.0

alset333 commented 4 years ago

Anticipated timeframe? This still seems to be unchanged in npm and trying to build is causing headaches personally.

AndiDittrich commented 4 years ago

i didn't noticed that there is a stable release of 3.x out - i'll release the changes asap

AndiDittrich commented 4 years ago

tagged 3.1.0 and published to npm