AndiDittrich / NodeMCU-Tool

:wrench: Upload + Manage Lua files on NodeMCU
https://www.npmjs.com/package/nodemcu-tool
MIT License
310 stars 54 forks source link

Glob arguments are not expanded on Windows #66

Closed ivkos closed 4 years ago

ivkos commented 4 years ago

So, in short, the issue is that executing the same command in bash works fine, and fails in Windows shells due to the lack of glob expansion. This makes it hard to set up some useful scripts in my package.json that work on all platforms.

A possible solution would be parsing the CLI arguments and checking with is-glob whether the arg looks like a glob, then resolving it with glob into a list of files.

AndiDittrich commented 4 years ago

Hi @ivkos,

i can add this as features request but i didn't have the time to implement it soon - maybe in the future..

ivkos commented 4 years ago

Thanks Andi. I'll see if I can help with this if I find some spare time.

AndiDittrich commented 4 years ago

i've just added a wrapper to invoke the glob expansion for the upload command

the expansion code is still empty (passthrough)

AndiDittrich commented 4 years ago

v3.2.0 is out including generic glob resolver