AndiDittrich / NodeMCU-Tool

:wrench: Upload + Manage Lua files on NodeMCU
https://www.npmjs.com/package/nodemcu-tool
MIT License
310 stars 54 forks source link

serialport bindings won't compile on modern Node #67

Closed stuartpb closed 4 years ago

stuartpb commented 4 years ago

64 noted that the native code in the version of serialport used by this script isn't supported on versions of Node greater than 10: seeing as how the current LTS is v12, this dependency should really be updated.

AndiDittrich commented 4 years ago

the project currently uses serialport v7 - issue #64 affects serialport <= v6

stuartpb commented 4 years ago

Well, v7 doesn't compile on Node v13, so the dependency still needs an update. I've got a PR for this (bumping the semver with no code changes works) that I'll be submitting in a sec.

AndiDittrich commented 4 years ago

compatibility for serialport v8 / NodeJS 12 LTS has been added to the master branch

AndiDittrich commented 4 years ago

v3.2.0 is out including the changes