AndiDittrich / NodeMCU-Tool

:wrench: Upload + Manage Lua files on NodeMCU
https://www.npmjs.com/package/nodemcu-tool
MIT License
310 stars 54 forks source link

add --noninteractive flag config #73

Closed bradshjg closed 4 years ago

bradshjg commented 4 years ago

Fixes #72

It felt kinda goofy writing about myself in the changelog...might save you a few seconds, feel free to throw away/modify (I don't need the publicity 😄)

I'm also really not sure what to do in the world of NodeJS, so this was definitely more "it looks like this should be here" more than "I fully understand what is happening and I know this change is reasonable".

AndiDittrich commented 4 years ago

Hi @bradshjg

thanks for your contribution. i've merged your PR but for the next time please read the contribution guidelines.

generally (this covers all kind of projects) PRs should never contain changes to the changelog or packaging files which are normally managed by the maintainers!