search

AndiLavera / mochi

Mochi is a authentication shard inspired by devise. Mochi is designed for the Amber framework with support for both Granite & Jennifer ORM's.
MIT License
25 stars 2 forks source link

Multi Router Controller Support #6

Open AndiLavera opened 4 years ago

AndiLavera commented 4 years ago

I really don't know how i feel about multi framework support right now. This PR is definitely being closed. I ported over some updates & specs from this PR into the master branch. What really remains the controllers.

I created an api which can be found in src/mochi/helpers/. The only 100% completed one is Amber but i did test the idea with athena & lucky with a proof-of-concept that looks like it worked.

My issue is it added so many new files & logic not related to authencation. Currently, i feel like I would spend more time fixing bugs related to controller logic rather than authentication logic.

This will sit open while i decide what do with multi router support.

alexanderadam commented 4 years ago

Would it make sense to split it up instead into a mochi_common shard and mochi_amber, mochi_lucky, …?