search

AndlyticsProject / andlytics

Google Play - Android Market statistics app
Other
536 stars 181 forks source link

Tablet UI #148

Open willlunniss opened 12 years ago

willlunniss commented 12 years ago

Any suggestions for small changes that could improve things? Or is this going to have to wait until we get some of the code moved into Fragments?

AndyScherzinger commented 12 years ago

I guess we have to move to fragments first even though that means another complete refactoring of the code base... :-(

AndyScherzinger commented 12 years ago

.. But I am open to any kind of improvement for tablets which don't require fragments though. :-)

nelenkov commented 12 years ago

Not necessarily. Adjusting margins, font sizes, etc. can make a huge difference. However, before this can be done, all of the formatting stuff that is now inline has to be moved to styles and dimensions. Also having alternative layouts for -land or -xlarge where it makes sense. We should also switch to the new smallestWidth qualifiers at some point (sw600dp, etc).

willlunniss commented 12 years ago

Well I was asking because I simply haven't looked into it yet. I'll have a go at setting up andlytics (well google account apks), on an emulator at some point.

willlunniss commented 12 years ago

Tablets (and large phones) now get a side by side chart and table view in landsacpe so that is a start at least.

nelenkov commented 12 years ago

This splits shows graph and table side by side in portrait mode too and my Nexus 7 and it doesn't look too great. The layout should probably be in layout-w600dp-land.

nelenkov commented 12 years ago

Another idea to make it look better: add layout_marginLeft and layout_marginRight to the main screen. Set to 0dp for phones, 100dp for w600dp-land. Otherwise it's too stretched out on a 9 or 10" screen.

nelenkov commented 12 years ago

This looks OK on my 7 and 9" tablets. Merge it if you want, but getting this right and consistent across the whole app is a lot of work, not sure if it should be in this release.

https://github.com/AndlyticsProject/andlytics/pull/164

willlunniss commented 12 years ago

Sorry I forgot the -land qualified, that was a mistake.

Well I figured at a minimum having a split layout would be worth it for landscape tablets, we can then rip it apart and use proper styles dimens values for 2.3.