search

AndlyticsProject / andlytics

Google Play - Android Market statistics app
Other
535 stars 181 forks source link

Refactor Internal Setter smell in BaseActivity class #768

Open emaiannone opened 4 years ago

emaiannone commented 4 years ago

Hi, I'm Emanuele Iannone, a master student at University of Salerno. Since my bachelor's thesis I have been working on a code smell refactoring plugin called aDoctor, which is able to identify and fix energy-related problems in Android apps. I launched it on your project, finding different instances of code smells. I chose one of them and let the plugin automatically fix it. In this case I chose Internal Setter, that is present when non static method calls a setter method of an instance variable instead of directly changing its value. These kind of smell may have a non trivial impact on energy consumption, as shown in this paper: https://www.sciencedirect.com/science/article/pii/S0950584918301678. Besides, this kind of refactoring does not impact on the functionalities of your app, so it is totally safe. Let me know if you are interested in this refactoring proposal.

AndyScherzinger commented 4 years ago

Hi @emaiannone,

thanks for taking an interest in Andlytics. I posted some comments to your code change. Also beware that this project isn't actively maintained anymore!

Cheers, Andy