Add support to lock down user for git commit to login via config

Andr3as / Codiad-CodeGit

Git integration for Codiad

MIT License

26 stars 15 forks source link

Add support to lock down user for git commit to login via config #29

Closed deitch closed 8 years ago

deitch commented 9 years ago

Enables a config file data/config/git.php to have a parameter lockuser, which, if set to true, forces the git commit username to be identical to the Codiad login name

Andr3as commented 8 years ago

I'll merge it with #28 and #27 to version 0.6.0.

Before that, I have some comments:

Please fix the whitespace
Change the filename to git.settings.php
(I use the following structure for other plugins to name config files:
- User config: PLUGIN.USER.php for user specific settings
- General config: PLUGIN.settings.php for general plugin settings)
Update the code to match the changes of #27

deitch commented 8 years ago

Please fix the whitespace

Can you be specific? What issue is there with the whitespace?

Change the filename to git.settings.php

Done

Update the code to match the changes of #27

Is that 0.6.0?

That is hard. Best process is the standard github process. If you merge 0.6.0 into master, it will cause this PR to fall out of sync. Then I can fix this to be in sync with master.

Andr3as commented 8 years ago

Whitespace

f.e. here

Change the filename to git.settings.php

Please change it here too

27

Merged

deitch commented 8 years ago

OK, fixed the whitespace and filename issue.

I see you merged it in. This PR and the other one will conflict with each other. I will fix the other one with 0.6.0, you can merge it in, then I will fix this one.

Andr3as commented 8 years ago

Great, :+1:

Andr3as commented 8 years ago

Merges and cleanup are done. Master branch is ready…

deitch commented 8 years ago

Got it. Always a pain to do the rebase to master. git needs an easier way to do it.

Andr3as commented 8 years ago

Thank you for contributing