Andr3as / Codiad-CodeGit

Git integration for Codiad
MIT License
26 stars 15 forks source link

"Please install shell program" with both Expect and pexpect #61

Closed 4oo4 closed 6 years ago

4oo4 commented 6 years ago

My issue is similar to #56, for whatever reason I can't get the plugin to connect with my git repos. I've verified that my git/ssh servers are able to accept incoming connections, and even though I've installed both expect as well as pexpect (globally as well as for the www-data user with virtualenv), I keep running into the "please install shell program" error. Is there a way that I can get some additional logging info to see what it's doing? Thanks again for the plugin!

4oo4 commented 6 years ago

Actually, I just figured this out, it turns out that my php.ini was too restrictive. I had the shell_exec function in disable_functions in my php.ini for security, I will do some testing to see what other security-sensitive functions it depends on. Then I can enable these one by one in a .user.ini file just for this application.

It seems that disable_functions can only be set in the master php.ini, so I may have to use git manually or live with the vulnerability :disappointed:

Even with git-php, it looks like git depends on the shell_exec / exec functions in order to work properly.