AndraxDev / speak-gpt

Your personal voice assistant based on OpenAI ChatGPT.
https://play.google.com/store/apps/details?id=org.teslasoft.assistant
Apache License 2.0
281 stars 59 forks source link

Feature Request: swiping up in the assistant to maximize its vertical space #88

Closed thiswillbeyourgithub closed 6 months ago

thiswillbeyourgithub commented 6 months ago

That would allow the assistant app to take more space. That would be useful because otherwise the LLM streaming text jumps every time a new line is added until you have enough text to manually scroll, which makes the scrolling unlocked from the text streaming, so no more jumping

AndraxDev commented 6 months ago

This feature makes no sense becaouse of the following reasons:

  1. If assistant output is large the text will still jump. I added feature that unlocks scrolling specially for this .
  2. Chat list is scrollable element so BottomSheetDialog will not handle the scroll event. Or if I use the scroll event inside chat list it will break layout and sometimes make chat unscrollable.