search

Andre-Joosten / mp-onlinevideos2

Automatically exported from code.google.com/p/mp-onlinevideos2
0 stars 0 forks source link

Empty parameters specified for RTMP proxy is not get into account #96

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. create RTMP proxy with empty parameter (e.g. parameter 'app' is empty 
string: 
http://127.0.0.1:30006/0/127.0.0.1/stream.flv?rtmpurl=rtmp://n05.joj.sk/dat/joj/
archiv/2011/05/02/joj-2-111060-0008-flv1-hq.flv&hostname=n05.joj.sk&tcUrl=rtmp:/
/n05.joj.sk&app=&playpath=dat/joj/archiv/2011/05/02/joj-2-111060-0008-flv1-hq.fl
v)
2. play video with this url

What is the expected output? What do you see instead?
Expected: playing video :)
Instead: Error "Unable to play video. No URL." occurs.

What version of MediaPortal are you using? On what operating system?
MP 1.1.3, OnlineVideos 0.29 (r1338), Windows 7 Ultimate 32-bit

What skin?
Blue3Wide

Please provide any additional information below.
When you look into MediaPortal.log you'll see that connection host failed to 
respond. When you look few lines before you'll see that 'app' parameter is: app 
: dat/joj. But in proxy it was specified as empty string. If the parameter 
'app' is empty, the video is played.

You can simulate same problem with rtmpdump.
Command with error:
rtmpdump -V -o "test.flv" -r 
"rtmp://n05.joj.sk/dat/joj/archiv/2011/05/05/joj-2-111032-0004-flv1-hq.flv" -t 
"rtmp://n05.joj.sk" -y "dat/joj/archiv/2011/05/05/joj-2-111032-0004-flv1-hq.flv"

Command without error (the 'app' parameter is empty string):
rtmpdump -V -o "test.flv" -r 
"rtmp://n05.joj.sk/dat/joj/archiv/2011/05/05/joj-2-111032-0004-flv1-hq.flv" -a 
"" -t "rtmp://n05.joj.sk" -y 
"dat/joj/archiv/2011/05/05/joj-2-111032-0004-flv1-hq.flv"

I have attached patch which fix the problem, but I don't known if it doesn't 
affect any other plugin using RTMP proxy.

Original issue reported on code.google.com by juraj.ho...@inmail.sk on 8 May 2011 at 9:45

Attachments:

GoogleCodeExporter commented 8 years ago 
Sounds good, I guess I someone supplied those params he wants to set them, so 
checking for null would be enough ;)
I'll do some testing and commit when I don't see problems,

Original comment by bborgsd...@gmail.com on 9 May 2011 at 10:22

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r1340.

Original comment by bborgsd...@gmail.com on 10 May 2011 at 9:05

GoogleCodeExporter commented 8 years ago 
Maybe same changes have to be done in RtmpUtil.cs from r1339 commit.

Original comment by juraj.ho...@inmail.sk on 10 May 2011 at 9:09