search

Andre0512 / pyhOn

Control hOn devices with python
MIT License
470 stars 1.76k forks source link

Water Heater. Ability to send only mandatory parameters #14

Closed VadymMelnychuk closed 1 year ago

VadymMelnychuk commented 1 year ago

In my case I have command StartProgram that has 3 parameters (Commands TestData Link):

But only onOffStatus is mandatory. The problem is when I send StartProgram command the body contains all 3 parameters with default values. As result I set tempSel to default value. Instead of this I want to send only mandatory parameters. I'm also preparing changes Hon repository as well

P.S. It might fix issue with on/off AC too

Andre0512 commented 1 year ago

Looks good so far, thanks! You can also use black locally to format the code 🙂 pip install black; black pyhon/

VadymMelnychuk commented 1 year ago

Thanks for help me with black :) Now it's fixed

VadymMelnychuk commented 1 year ago

@Andre0512 I added more options to manage the process of sending command

Andre0512 commented 1 year ago

Good work, I think this can also resolve the new issue https://github.com/Andre0512/hon/issues/92 :slightly_smiling_face: To get the actions running, have a look at the python-check.yml. You can test the action local if you run:


pip install -r requirements_dev.txt
flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=88 --statistics
mypy pyhon/
pylint  $(git ls-files '*.py')
black . --check```
Andre0512 commented 1 year ago

Thanks! It's now available in the new version v0.15.0 :slightly_smiling_face: