search

AndreBL / ip6neigh

Giving local DNS names to IPv6 SLAAC addresses [OpenWrt/LEDE shell script]
GNU General Public License v2.0
118 stars 15 forks source link

Multiple interfaces possible #10

Open DerPeit opened 4 years ago

DerPeit commented 4 years ago

Thank you for your project. It works fine on the most recent OpenWRT version. Is it possible to support more than one logical interface? If not, any hint will be appreciated where to look at to change the script.

Fail-Safe commented 4 years ago

I would like to see the same feature added. In addition to 'lan' interface, I also have guest and IoT interfaces with different IPv6 PD addressing.

DerPeit commented 4 years ago

Actually, I did it myself already. I adjusted the scripts so they accept the interface as a command line argument and spawned a process for each interface. Works so far. I did not publish it to GitHub, though, because I am not absolutely sure that every bit and piece works as intended. It works well for me, but I don't want to put something possibly harmful on the internet.

~If @AndreBL is willing to review pull requests I might create one, though.~

I added a pull request. @Fail-Safe maybe you can use this as a starting point.

Fail-Safe commented 4 years ago

Fantastic! I will give it a try and provide feedback on the PR in case @AndreBL is interested in pulling it.

AndreBL commented 4 years ago

Hello guys. I haven't had much time available to update this project, but I saw the changes you made for yourself and the pull request. As soon as I can I will test it on my router, to see if in my setup everything else works as before. One 1043nd router, old OpenWrt version, single dynamic /64 prefix from ISP, single lan using this prefix plus ULA prefix.

Fail-Safe commented 4 years ago

@DerPeit Finally got a chance to reply. So far, so good! It's working great with two interfaces where I have IPv6 SLAAC enabled on two different PD subnets.

@AndreBL Hopefully it continues to work well for your configuration as well. Would love to see this PR accepted. I think this will benefit a lot of OpenWRT users.

I'm also going to read up on how to roll this into an OpenWRT package. Would be glad to help contribute to this project if I can figure it out. 👍

DerPeit commented 4 years ago

Glad to hear that it works for you. It could be improved, though, i.e. by reducing copy and pasted code. But as I said I did it just for myself in the first place and did not want to spend a lot of time. I did not test snooping for example because I don't need this feature. So @AndreBL if you have sort of a test suite that'd possibly be good.

One thing to mention: I deleted log-file removal for obvious reasons: Since I changed the scripts so one process is spawned per interface they'd concurrently try to remove the log file. I have a router with plenty of space so it was not an issue. If that's an issue for other environments it may make sense to split logging to several files and reintroducing deletion or similar.