AndreHaueisen / flushbar

Custom widget for Flutter
Other
1.01k stars 172 forks source link

Parameter names should be reversed. #144

Open ThinkDigitalSoftware opened 4 years ago

ThinkDigitalSoftware commented 4 years ago

/// The title displayed to the user final String title;

/// The message displayed to the user. final String message;

/// Replaces [title]. Although this accepts a [Widget], it is meant to receive [Text] or [RichText] final Widget titleText;

/// Replaces [message]. Although this accepts a [Widget], it is meant to receive [Text] or [RichText] final Widget messageText;

If this were to be consistent with Flutter naming schemes, we'd swap the names. title should be a Widget, and titleText should be a String. Take InputDecoration for example.

Screen Shot 2020-05-29 at 3 48 45 PM
mohak852 commented 4 years ago

@AndreHaueisen can you assign this issue to me?