search

AndreMiras / EtherollApp

Provably fair dice game running on the Ethereum blockchain
MIT License
57 stars 22 forks source link

Tox pre-install merged upstream #113

Closed AndreMiras closed 5 years ago

AndreMiras commented 6 years ago

Since the tox pre command was merged upstream https://github.com/tox-dev/tox/pull/1000 we can now remove this hack https://github.com/AndreMiras/EtherollApp/blob/v20180918/tox.ini#L8 (once new tox version is released).

AndreMiras commented 6 years ago

The fix is part of tox==3.4.0 https://github.com/tox-dev/tox/releases/tag/3.4.0 Ubuntu Bionic currently runs under tox==2.5.0

tox --version
2.5.0 imported from /usr/lib/python3/dist-packages/tox/__init__.py

It means the Makefile probably needs to enforce the update.