search

AndreMiras / EtherollApp

Provably fair dice game running on the Ethereum blockchain
MIT License
57 stars 22 forks source link

Hardcoded /sdcard/ call #145

Open AndreMiras opened 5 years ago

AndreMiras commented 5 years ago

Try to use e.g. getExternalStoragePublicDirectory() or getExternalFilesDir() rather than /sdcard/ since the location may vary. Double check to make sure to pick up one that persists upon app deletion. See: https://stackoverflow.com/questions/26579869/how-can-i-let-users-access-the-internal-storage-directory-of-my-app

AndreMiras commented 5 years ago

Also ref p4a upstream WIP PR https://github.com/kivy/python-for-android/pull/1598

AndreMiras commented 4 years ago

I gave it another go and things are not as I expected regarding the /sdcard/ path. It looks like none of the API methods would return that path directly. This is the output I get from adb logcat:

09-27 16:54:07.997 14483 14520 I python  : Initializing Python for Android                                                                                                                                                                                                                                                             
09-27 16:54:07.997 14483 14520 I python  : Setting additional env vars from p4a_env_vars.txt                                                                                                                                                                                                                                           
09-27 16:54:07.997 14483 14520 I python  : Changing directory to the one provided by ANDROID_ARGUMENT                                                                                                                                                                                                                                  
09-27 16:54:07.997 14483 14520 I python  : /data/user/0/org.test.myapp/files/app
09-27 16:54:07.997 14483 14520 I python  : Preparing to initialize python
09-27 16:54:07.997 14483 14520 I python  : _python_bundle dir exists
09-27 16:54:07.997 14483 14520 I python  : calculated paths to be...
09-27 16:54:07.997 14483 14520 I python  : /data/user/0/org.test.myapp/files/app/_python_bundle/stdlib.zip:/data/user/0/org.test.myapp/files/app/_python_bundle/modules
09-27 16:54:07.997 14483 14520 I python  : set wchar paths...
09-27 16:54:08.021 14483 14520 I python  : Initialized python
09-27 16:54:08.021 14483 14520 I python  : AND: Init threads
09-27 16:54:08.021 14483 14520 I python  : testing python print redirection
09-27 16:54:08.022 14483 14520 I python  : Android path ['.', '/data/user/0/org.test.myapp/files/app/_python_bundle/stdlib.zip', '/data/user/0/org.test.myapp/files/app/_python_bundle/modules', '/data/user/0/org.test.myapp/files/app/_python_bundle/site-packages']
09-27 16:54:08.022 14483 14520 I python  : os.environ is environ({'PATH': '/sbin:/system/sbin:/system/bin:/system/xbin:/vendor/bin:/vendor/xbin', 'DOWNLOAD_CACHE': '/data/cache', 'ANDROID_BOOTLOGO': '1', 'ANDROID_ROOT': '/system', 'ANDROID_ASSETS': '/system/app', 'ANDROID_DATA': '/data', 'ANDROID_STORAGE': '/storage', 'EXTERN
AL_STORAGE': '/sdcard', 'ASEC_MOUNTPOINT': '/mnt/asec', 'BOOTCLASSPATH': '/system/framework/core-oj.jar:/system/framework/core-libart.jar:/system/framework/conscrypt.jar:/system/framework/okhttp.jar:/system/framework/bouncycastle.jar:/system/framework/apache-xml.jar:/system/framework/legacy-test.jar:/system/framework/ext.jar:
/system/framework/framework.jar:/system/framework/telephony-common.jar:/system/framework/voip-common.jar:/system/framework/ims-common.jar:/system/framework/org.apache.http.legacy.boot.jar:/system/framework/android.hidl.base-V1.0-java.jar:/system/framework/android.hidl.manager-V1.0-java.jar', 'SYSTEMSERVERCLASSPATH': '/system/
framework/services.jar:/system/framework/ethernet-service.jar:/system/framework/wifi-service.jar:/system/framework/com.android.location.provider.jar', 'ANDROID_SOCKET_zygote': '9', 'ANDROID_ENTRYPOINT': 'main.pyc', 'ANDROID_ARGUMENT': '/data/user/0/org.test.myapp/files/app', 'ANDROID_APP_PATH': '/data/user/0/org.test.myapp/fi
les/app', 'ANDROID_PRIVATE': '/data/user/0/org.test.myapp/files', 'ANDROID_UNPACK': '/data/user/0/org.test.myapp/files/app', 'PYTHONHOME': '/data/user/0/org.test.myapp/files/app', 'PYTHONPATH': '/data/user/0/org.test.myapp/files/app:/data/user/0/org.test.myapp/files/app/lib', 'PYTHONOPTIMIZE': '2', 'P4A_BOOTSTRAP': 'SDL2', 'P
YTHON_NAME': 'python', 'P4A_IS_WINDOWED': 'True', 'P4A_ORIENTATION': 'portrait', 'P4A_NUMERIC_VERSION': 'None', 'P4A_MINSDK': '21', 'LC_CTYPE': 'C.UTF-8'})
09-27 16:54:08.022 14483 14520 I python  : Android kivy bootstrap done. __name__ is __main__
09-27 16:54:08.022 14483 14520 I python  : AND: Ran string
09-27 16:54:08.022 14483 14520 I python  : Run user program, change dir and execute entrypoint
09-27 16:54:08.405 14483 14520 I python  : app_storage_path: /data/user/0/org.test.myapp/files
09-27 16:54:08.436 14483 14520 I python  : primary_external_storage_path: /storage/emulated/0
09-27 16:54:08.441 14483 14520 I python  : secondary_external_storage_path: None
09-27 16:54:08.441 14483 14520 I python  : get_external_storage_public_directory:
09-27 16:54:08.444 14483 14520 I python  : dir_type: Music; path: /storage/emulated/0/Music
09-27 16:54:08.447 14483 14520 I python  : dir_type: Podcasts; path: /storage/emulated/0/Podcasts
09-27 16:54:08.449 14483 14520 I python  : dir_type: Ringtones; path: /storage/emulated/0/Ringtones
09-27 16:54:08.454 14483 14520 I python  : dir_type: Alarms; path: /storage/emulated/0/Alarms
09-27 16:54:08.457 14483 14520 I python  : dir_type: Notifications; path: /storage/emulated/0/Notifications
09-27 16:54:08.458 14483 14520 I python  : dir_type: Pictures; path: /storage/emulated/0/Pictures
09-27 16:54:08.459 14483 14520 I python  : dir_type: Movies; path: /storage/emulated/0/Movies
09-27 16:54:08.459 14483 14520 I python  : dir_type: Download; path: /storage/emulated/0/Download
09-27 16:54:08.460 14483 14520 I python  : dir_type: DCIM; path: /storage/emulated/0/DCIM
09-27 16:54:08.461 14483 14520 I python  : dir_type: Documents; path: /storage/emulated/0/Documents
09-27 16:54:08.461 14483 14520 I python  : external_storage_public_directory: ['/storage/emulated/0/Music', '/storage/emulated/0/Podcasts', '/storage/emulated/0/Ringtones', '/storage/emulated/0/Alarms', '/storage/emulated/0/Notifications', '/storage/emulated/0/Pictures', '/storage/emulated/0/Movies', '/storage/emulated/0/Down
load', '/storage/emulated/0/DCIM', '/storage/emulated/0/Documents']
09-27 16:54:08.461 14483 14520 I python  : get_external_files_dir:
09-27 16:54:08.463 14483 14520 I python  : dir_type: Music; path: /storage/emulated/0/Android/data/org.test.myapp/files/Music
09-27 16:54:08.464 14483 14520 I python  : dir_type: Podcasts; path: /storage/emulated/0/Android/data/org.test.myapp/files/Podcasts
09-27 16:54:08.465 14483 14520 I python  : dir_type: Ringtones; path: /storage/emulated/0/Android/data/org.test.myapp/files/Ringtones
09-27 16:54:08.465 14483 14520 I python  : dir_type: Alarms; path: /storage/emulated/0/Android/data/org.test.myapp/files/Alarms
09-27 16:54:08.466 14483 14520 I python  : dir_type: Notifications; path: /storage/emulated/0/Android/data/org.test.myapp/files/Notifications
09-27 16:54:08.467 14483 14520 I python  : dir_type: Pictures; path: /storage/emulated/0/Android/data/org.test.myapp/files/Pictures
09-27 16:54:08.468 14483 14520 I python  : dir_type: Movies; path: /storage/emulated/0/Android/data/org.test.myapp/files/Movies
09-27 16:54:08.469 14483 14520 I python  : dir_type: Download; path: /storage/emulated/0/Android/data/org.test.myapp/files/Download
09-27 16:54:08.470 14483 14520 I python  : dir_type: DCIM; path: /storage/emulated/0/Android/data/org.test.myapp/files/DCIM
09-27 16:54:08.471 14483 14520 I python  : dir_type: Documents; path: /storage/emulated/0/Android/data/org.test.myapp/files/Documents
09-27 16:54:08.471 14483 14520 I python  : external_files_dir: ['/storage/emulated/0/Android/data/org.test.myapp/files/Music', '/storage/emulated/0/Android/data/org.test.myapp/files/Podcasts', '/storage/emulated/0/Android/data/org.test.myapp/files/Ringtones', '/storage/emulated/0/Android/data/org.test.myapp/files/Alarms', '/s
torage/emulated/0/Android/data/org.test.myapp/files/Notifications', '/storage/emulated/0/Android/data/org.test.myapp/files/Pictures', '/storage/emulated/0/Android/data/org.test.myapp/files/Movies', '/storage/emulated/0/Android/data/org.test.myapp/files/Download', '/storage/emulated/0/Android/data/org.test.myapp/files/DCIM', '
/storage/emulated/0/Android/data/org.test.myapp/files/Documents']
09-27 16:54:08.471 14483 14520 I python  : get_external_files_dir:
09-27 16:54:08.476 14483 14520 I python  : dir_type: Music; path: /storage/emulated/0/Android/data/org.test.myapp/files/Music
09-27 16:54:08.478 14483 14520 I python  : dir_type: Podcasts; path: /storage/emulated/0/Android/data/org.test.myapp/files/Podcasts
09-27 16:54:08.482 14483 14520 I python  : dir_type: Ringtones; path: /storage/emulated/0/Android/data/org.test.myapp/files/Ringtones
09-27 16:54:08.486 14483 14520 I python  : dir_type: Alarms; path: /storage/emulated/0/Android/data/org.test.myapp/files/Alarms
09-27 16:54:08.490 14483 14520 I python  : dir_type: Notifications; path: /storage/emulated/0/Android/data/org.test.myapp/files/Notifications
09-27 16:54:08.495 14483 14520 I python  : dir_type: Pictures; path: /storage/emulated/0/Android/data/org.test.myapp/files/Pictures
09-27 16:54:08.500 14483 14520 I python  : dir_type: Movies; path: /storage/emulated/0/Android/data/org.test.myapp/files/Movies
09-27 16:54:08.504 14483 14520 I python  : dir_type: Download; path: /storage/emulated/0/Android/data/org.test.myapp/files/Download
09-27 16:54:08.509 14483 14520 I python  : dir_type: DCIM; path: /storage/emulated/0/Android/data/org.test.myapp/files/DCIM
09-27 16:54:08.517 14483 14520 I python  : dir_type: Documents; path: /storage/emulated/0/Android/data/org.test.myapp/files/Documents
09-27 16:54:08.517 14483 14520 I python  : get_external_storage_public_directory:
09-27 16:54:08.524 14483 14520 I python  : dir_type: Music; path: /storage/emulated/0/Music
09-27 16:54:08.531 14483 14520 I python  : dir_type: Podcasts; path: /storage/emulated/0/Podcasts
09-27 16:54:08.536 14483 14520 I python  : dir_type: Ringtones; path: /storage/emulated/0/Ringtones
09-27 16:54:08.545 14483 14520 I python  : dir_type: Alarms; path: /storage/emulated/0/Alarms
09-27 16:54:08.551 14483 14520 I python  : dir_type: Notifications; path: /storage/emulated/0/Notifications
09-27 16:54:08.555 14483 14520 I python  : dir_type: Pictures; path: /storage/emulated/0/Pictures
09-27 16:54:08.565 14483 14520 I python  : dir_type: Movies; path: /storage/emulated/0/Movies
09-27 16:54:08.570 14483 14520 I python  : dir_type: Download; path: /storage/emulated/0/Download
09-27 16:54:08.576 14483 14520 I python  : dir_type: DCIM; path: /storage/emulated/0/DCIM
09-27 16:54:08.585 14483 14520 I python  : dir_type: Documents; path: /storage/emulated/0/Documents
09-27 16:54:08.586 14483 14520 I python  : Python for android ended.

And here the main.py I used:

from android import storage
from jnius import autoclass, cast

Environment = autoclass('android.os.Environment')

def get_external_files_dir():
    print('get_external_files_dir:')
    activity = storage._get_activity()
    currentActivity = cast('android.app.Activity', activity)
    context = cast(
        'android.content.ContextWrapper',
        currentActivity.getApplicationContext())
    dir_types = (
        Environment.DIRECTORY_MUSIC,
        Environment.DIRECTORY_PODCASTS,
        Environment.DIRECTORY_RINGTONES,
        Environment.DIRECTORY_ALARMS,
        Environment.DIRECTORY_NOTIFICATIONS,
        Environment.DIRECTORY_PICTURES,
        Environment.DIRECTORY_MOVIES,
        Environment.DIRECTORY_DOWNLOADS,
        Environment.DIRECTORY_DCIM,
        Environment.DIRECTORY_DOCUMENTS,
    )
    paths = []
    for dir_type in dir_types:
        file_obj = cast('java.io.File', context.getExternalFilesDir(dir_type))
        path = file_obj.getAbsolutePath()
        print(f'dir_type: {dir_type}; path: {path}')
        paths.append(path)
    return paths

def get_external_storage_public_directory():
    print('get_external_storage_public_directory:')
    dir_types = (
        Environment.DIRECTORY_MUSIC,
        Environment.DIRECTORY_PODCASTS,
        Environment.DIRECTORY_RINGTONES,
        Environment.DIRECTORY_ALARMS,
        Environment.DIRECTORY_NOTIFICATIONS,
        Environment.DIRECTORY_PICTURES,
        Environment.DIRECTORY_MOVIES,
        Environment.DIRECTORY_DOWNLOADS,
        Environment.DIRECTORY_DCIM,
        Environment.DIRECTORY_DOCUMENTS,
    )
    paths = []
    for dir_type in dir_types:
        file_obj = Environment.getExternalStoragePublicDirectory(dir_type)
        path = file_obj.getAbsolutePath()
        print(f'dir_type: {dir_type}; path: {path}')
        paths.append(path)
    return paths

def get_storage_paths():
    app_storage_path = storage.app_storage_path()
    print('app_storage_path:', app_storage_path)
    primary_external_storage_path = storage.primary_external_storage_path()
    print('primary_external_storage_path:', primary_external_storage_path)
    secondary_external_storage_path = storage.secondary_external_storage_path()
    print('secondary_external_storage_path:', secondary_external_storage_path)
    external_storage_public_directory = get_external_storage_public_directory()
    print('external_storage_public_directory:',
          external_storage_public_directory)
    external_files_dir = get_external_files_dir()
    print('external_files_dir:', external_files_dir)

def main():
    get_storage_paths()
    get_external_files_dir()
    get_external_storage_public_directory()

if __name__ == '__main__':
    main()

And buildozer.spec:

[app]

# (str) Title of your application
title = My Application

# (str) Package name
package.name = myapp

# (str) Package domain (needed for android/ios packaging)
package.domain = org.test

# (str) Source code where the main.py live
source.dir = .

# (list) Source files to include (let empty to include all the files)
source.include_exts = py,png,jpg,kv,atlas

# (list) List of inclusions using pattern matching
#source.include_patterns = assets/*,images/*.png

# (list) Source files to exclude (let empty to not exclude anything)
#source.exclude_exts = spec

# (list) List of directory to exclude (let empty to not exclude anything)
#source.exclude_dirs = tests, bin

# (list) List of exclusions using pattern matching
#source.exclude_patterns = license,images/*/*.jpg

# (str) Application versioning (method 1)
version = 0.1

# (str) Application versioning (method 2)
# version.regex = __version__ = ['"](.*)['"]
# version.filename = %(source.dir)s/main.py

# (list) Application requirements
# comma separated e.g. requirements = sqlite3,kivy
requirements = python3,kivy,android

# (str) Custom source folders for requirements
# Sets custom source for any requirements with recipes
# requirements.source.kivy = ../../kivy

# (list) Garden requirements
#garden_requirements =

# (str) Presplash of the application
#presplash.filename = %(source.dir)s/data/presplash.png

# (str) Icon of the application
#icon.filename = %(source.dir)s/data/icon.png

# (str) Supported orientation (one of landscape, sensorLandscape, portrait or all)
orientation = portrait

# (list) List of service to declare
#services = NAME:ENTRYPOINT_TO_PY,NAME2:ENTRYPOINT2_TO_PY

#
# OSX Specific
#

#
# author = © Copyright Info

# change the major version of python used by the app
osx.python_version = 3

# Kivy version to use
osx.kivy_version = 1.9.1

#
# Android specific
#

# (bool) Indicate if the application should be fullscreen or not
fullscreen = 0

# (string) Presplash background color (for new android toolchain)
# Supported formats are: #RRGGBB #AARRGGBB or one of the following names:
# red, blue, green, black, white, gray, cyan, magenta, yellow, lightgray,
# darkgray, grey, lightgrey, darkgrey, aqua, fuchsia, lime, maroon, navy,
# olive, purple, silver, teal.
#android.presplash_color = #FFFFFF

# (list) Permissions
#android.permissions = INTERNET

# (int) Target Android API, should be as high as possible.
#android.api = 27

# (int) Minimum API your APK will support.
#android.minapi = 21

# (int) Android SDK version to use
#android.sdk = 20

# (str) Android NDK version to use
#android.ndk = 17c

# (int) Android NDK API to use. This is the minimum API your app will support, it should usually match android.minapi.
#android.ndk_api = 21

# (bool) Use --private data storage (True) or --dir public storage (False)
#android.private_storage = True

# (str) Android NDK directory (if empty, it will be automatically downloaded.)
#android.ndk_path =

# (str) Android SDK directory (if empty, it will be automatically downloaded.)
#android.sdk_path =

# (str) ANT directory (if empty, it will be automatically downloaded.)
#android.ant_path =

# (bool) If True, then skip trying to update the Android sdk
# This can be useful to avoid excess Internet downloads or save time
# when an update is due and you just want to test/build your package
# android.skip_update = False

# (bool) If True, then automatically accept SDK license
# agreements. This is intended for automation only. If set to False,
# the default, you will be shown the license when first running
# buildozer.
# android.accept_sdk_license = False

# (str) Android entry point, default is ok for Kivy-based app
#android.entrypoint = org.renpy.android.PythonActivity

# (list) Pattern to whitelist for the whole project
#android.whitelist =

# (str) Path to a custom whitelist file
#android.whitelist_src =

# (str) Path to a custom blacklist file
#android.blacklist_src =

# (list) List of Java .jar files to add to the libs so that pyjnius can access
# their classes. Don't add jars that you do not need, since extra jars can slow
# down the build process. Allows wildcards matching, for example:
# OUYA-ODK/libs/*.jar
#android.add_jars = foo.jar,bar.jar,path/to/more/*.jar

# (list) List of Java files to add to the android project (can be java or a
# directory containing the files)
#android.add_src =

# (list) Android AAR archives to add (currently works only with sdl2_gradle
# bootstrap)
#android.add_aars =

# (list) Gradle dependencies to add (currently works only with sdl2_gradle
# bootstrap)
#android.gradle_dependencies =

# (list) Java classes to add as activities to the manifest.
#android.add_activites = com.example.ExampleActivity

# (str) OUYA Console category. Should be one of GAME or APP
# If you leave this blank, OUYA support will not be enabled
#android.ouya.category = GAME

# (str) Filename of OUYA Console icon. It must be a 732x412 png image.
#android.ouya.icon.filename = %(source.dir)s/data/ouya_icon.png

# (str) XML file to include as an intent filters in <activity> tag
#android.manifest.intent_filters =

# (str) launchMode to set for the main activity
#android.manifest.launch_mode = standard

# (list) Android additional libraries to copy into libs/armeabi
#android.add_libs_armeabi = libs/android/*.so
#android.add_libs_armeabi_v7a = libs/android-v7/*.so
#android.add_libs_arm64_v8a = libs/android-v8/*.so
#android.add_libs_x86 = libs/android-x86/*.so
#android.add_libs_mips = libs/android-mips/*.so

# (bool) Indicate whether the screen should stay on
# Don't forget to add the WAKE_LOCK permission if you set this to True
#android.wakelock = False

# (list) Android application meta-data to set (key=value format)
#android.meta_data =

# (list) Android library project to add (will be added in the
# project.properties automatically.)
#android.library_references =

# (list) Android shared libraries which will be added to AndroidManifest.xml using <uses-library> tag
#android.uses_library =

# (str) Android logcat filters to use
#android.logcat_filters = *:S python:D

# (bool) Copy library instead of making a libpymodules.so
#android.copy_libs = 1

# (str) The Android arch to build for, choices: armeabi-v7a, arm64-v8a, x86, x86_64
# android.arch = armeabi-v7a
android.arch = x86

#
# Python for android (p4a) specific
#

# (str) python-for-android fork to use, defaults to upstream (kivy)
p4a.fork = kivy

# (str) python-for-android branch to use, defaults to master
p4a.branch = develop

# (str) python-for-android git clone directory (if empty, it will be automatically cloned from github)
#p4a.source_dir =

# (str) The directory in which python-for-android should look for your own build recipes (if any)
#p4a.local_recipes =

# (str) Filename to the hook for p4a
#p4a.hook =

# (str) Bootstrap to use for android builds
# p4a.bootstrap = sdl2

# (int) port number to specify an explicit --port= p4a argument (eg for bootstrap flask)
#p4a.port =

#
# iOS specific
#

# (str) Path to a custom kivy-ios folder
#ios.kivy_ios_dir = ../kivy-ios
# Alternately, specify the URL and branch of a git checkout:
ios.kivy_ios_url = https://github.com/kivy/kivy-ios
ios.kivy_ios_branch = master

# Another platform dependency: ios-deploy
# Uncomment to use a custom checkout
#ios.ios_deploy_dir = ../ios_deploy
# Or specify URL and branch
ios.ios_deploy_url = https://github.com/phonegap/ios-deploy
ios.ios_deploy_branch = 1.7.0

# (str) Name of the certificate to use for signing the debug version
# Get a list of available identities: buildozer ios list_identities
#ios.codesign.debug = "iPhone Developer: <lastname> <firstname> (<hexstring>)"

# (str) Name of the certificate to use for signing the release version
#ios.codesign.release = %(ios.codesign.debug)s

[buildozer]

# (int) Log level (0 = error only, 1 = info, 2 = debug (with command output))
log_level = 2

# (int) Display warning if buildozer is run as root (0 = False, 1 = True)
warn_on_root = 1

# (str) Path to build artifact storage, absolute or relative to spec file
# build_dir = ./.buildozer

# (str) Path to build output (i.e. .apk, .ipa) storage
# bin_dir = ./bin

#    -----------------------------------------------------------------------------
#    List as sections
#
#    You can define all the "list" as [section:key].
#    Each line will be considered as a option to the list.
#    Let's take [app] / source.exclude_patterns.
#    Instead of doing:
#
#[app]
#source.exclude_patterns = license,data/audio/*.wav,data/images/original/*
#
#    This can be translated into:
#
#[app:source.exclude_patterns]
#license
#data/audio/*.wav
#data/images/original/*
#

#    -----------------------------------------------------------------------------
#    Profiles
#
#    You can extend section / key with a profile
#    For example, you want to deploy a demo version of your application without
#    HD content. You could first change the title to add "(demo)" in the name
#    and extend the excluded directories to remove the HD content.
#
#[app@demo]
#title = My Application (demo)
#
#[app:source.exclude_patterns@demo]
#images/hd/*
#
#    Then, invoke the command line with the "demo" profile:
#
#buildozer --profile demo android debug